Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1778283002: Add CONTENT_EXPORT for content::MediaStreamAudioLevelCalculator::Level. (Closed)

Created:
4 years, 9 months ago by Lei Zhang
Modified:
4 years, 9 months ago
Reviewers:
Henrik Grunell, miu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CONTENT_EXPORT for content::MediaStreamAudioLevelCalculator::Level. This is a speculative fix. BUG=593591 TBR=miu@chromium.org,grunell@chromium.org Committed: https://crrev.com/e0f58d4aab12dc80cf372899966ecfe652499910 Cr-Commit-Position: refs/heads/master@{#380367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/media_stream_audio_level_calculator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
TBR, I've got 25 DrMemory bots idling because of this. Hope it works.
4 years, 9 months ago (2016-03-10 06:00:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778283002/1
4 years, 9 months ago (2016-03-10 06:01:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 07:15:54 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0f58d4aab12dc80cf372899966ecfe652499910 Cr-Commit-Position: refs/heads/master@{#380367}
4 years, 9 months ago (2016-03-10 07:17:35 UTC) #6
Henrik Grunell
lgtm
4 years, 9 months ago (2016-03-10 16:42:42 UTC) #7
miu
lgtm Apologies. I thought nested classes of exported classes were also exported. But, maybe MS ...
4 years, 9 months ago (2016-03-10 20:45:49 UTC) #8
miu
4 years, 9 months ago (2016-03-10 20:48:10 UTC) #9
Message was sent while issue was closed. 
On 2016/03/10 20:45:49, miu wrote:
> lgtm
> 
> Apologies.  I thought nested classes of exported classes were also exported. 
> But, maybe MS Visual Studio is different?  Perhaps there should be a Dr.
Memory
> builder in the CQ?

...just checked the waterfall, and this seems to have fixed the compile problem.

Powered by Google App Engine
This is Rietveld 408576698