Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1778243008: depot_tools: use ninja.exe instead of just ninja on Windows (Closed)

Created:
4 years, 9 months ago by Paweł Hajdan Jr.
Modified:
4 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: use ninja.exe instead of just ninja on Windows BUG=437264 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M recipe_modules/depot_tools/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/depot_tools/api.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Paweł Hajdan Jr.
4 years, 9 months ago (2016-03-12 02:29:23 UTC) #2
iannucci
lgtm
4 years, 9 months ago (2016-03-12 02:31:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778243008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778243008/1
4 years, 9 months ago (2016-03-12 02:31:53 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 02:34:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299267

Powered by Google App Engine
This is Rietveld 408576698