Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: net/quic/quic_alarm.h

Issue 1778243005: Call QuicAlarm::IsSet instead of looking at deadline_ directly, rename some variables for readabili… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116142833
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_alarm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_alarm.h
diff --git a/net/quic/quic_alarm.h b/net/quic/quic_alarm.h
index a775cfb523968f72e95b72981643c45552c7f5b0..9bd7279e7b760bcaa83ed0dc562d2544ad3eefed 100644
--- a/net/quic/quic_alarm.h
+++ b/net/quic/quic_alarm.h
@@ -36,7 +36,7 @@ class NET_EXPORT_PRIVATE QuicAlarm {
// Sets the alarm to fire at |deadline|. Must not be called while
// the alarm is set. To reschedule an alarm, call Cancel() first,
// then Set().
- void Set(QuicTime deadline);
+ void Set(QuicTime new_deadline);
// Cancels the alarm. May be called repeatedly. Does not
// guarantee that the underlying scheduling system will remove
@@ -47,8 +47,9 @@ class NET_EXPORT_PRIVATE QuicAlarm {
// Cancels and sets the alarm if the |deadline| is farther from the current
// deadline than |granularity|, and otherwise does nothing. If |deadline| is
// not initialized, the alarm is cancelled.
- void Update(QuicTime deadline, QuicTime::Delta granularity);
+ void Update(QuicTime new_deadline, QuicTime::Delta granularity);
+ // Returns true if |deadline_| has been set to a non-zero time.
bool IsSet() const;
QuicTime deadline() const { return deadline_; }
« no previous file with comments | « no previous file | net/quic/quic_alarm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698