Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1778243003: MacViews: Fix MenuControllerTest.SelectChildButtonView (Closed)

Created:
4 years, 9 months ago by tapted
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix MenuControllerTest.SelectChildButtonView Above the declaration for MenuController::OnMouseMoved(..) it says // NOTE: the coordinates of the events are in that of the // MenuScrollViewContainer. But the test wasn't doing that. I think on Mac the menu Widget is shifted down by the height of the main menu bar, so the test couldn't assume it's at the top left of the screen. BUG=592890 Committed: https://crrev.com/bb2a58ae2441fbfa4f5168baab1b1a5c0c047916 Cr-Commit-Position: refs/heads/master@{#380500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ui/views/controls/menu/menu_controller_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tapted
Hi sky, please take a look
4 years, 9 months ago (2016-03-10 06:15:20 UTC) #3
sky
LGTM
4 years, 9 months ago (2016-03-10 17:09:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778243003/1
4 years, 9 months ago (2016-03-10 23:48:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 00:22:41 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 00:24:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb2a58ae2441fbfa4f5168baab1b1a5c0c047916
Cr-Commit-Position: refs/heads/master@{#380500}

Powered by Google App Engine
This is Rietveld 408576698