Move mach code shared by Chrome IPC and Mojo to //base/mac.

Move mach code shared by Chrome IPC and Mojo to //base/mac.

BUG=582468
Committed: https://crrev.com/e04cef7c43dc8c9562f41e3fc51fef73f48da05a
Cr-Commit-Position: refs/heads/master@{#380855}

[Anand Mistry (off Chromium), 2016-03-10 02:56:37]

amistry@chromium.org changed reviewers:
+ erikchen@chromium.org, mark@chromium.org

[Anand Mistry (off Chromium), 2016-03-10 02:56:37]

This change just moves some code around. No changes to the actual code except
for CreateIntermediatePort which needs to return an error code so that it can be
logged to UMA by the attachment broker.

[erikchen, 2016-03-10 17:54:09]

lgtm

https://codereview.chromium.org/1778203002/diff/40001/base/mac/mach_port_util.h
File base/mac/mach_port_util.h (right):

https://codereview.chromium.org/1778203002/diff/40001/base/mac/mach_port_util...
base/mac/mach_port_util.h:32: // defined in
IPC::AttachmentBrokerPrivileged::UMAError.
Use an enum here, and have IPC::AttachmentBrokerPrivileged do the conversion
from this enum to the UMA values..

[Mark Mentovai, 2016-03-10 18:05:22]

LGTM

[Anand Mistry (off Chromium), 2016-03-11 00:29:04]

https://codereview.chromium.org/1778203002/diff/40001/base/mac/mach_port_util.h
File base/mac/mach_port_util.h (right):

https://codereview.chromium.org/1778203002/diff/40001/base/mac/mach_port_util...
base/mac/mach_port_util.h:32: // defined in
IPC::AttachmentBrokerPrivileged::UMAError.
On 2016/03/10 17:54:09, erikchen wrote:
> Use an enum here, and have IPC::AttachmentBrokerPrivileged do the conversion
> from this enum to the UMA values..

Is this what you had in mind?

[erikchen, 2016-03-11 00:30:56]

https://codereview.chromium.org/1778203002/diff/40001/base/mac/mach_port_util.h
File base/mac/mach_port_util.h (right):

https://codereview.chromium.org/1778203002/diff/40001/base/mac/mach_port_util...
base/mac/mach_port_util.h:32: // defined in
IPC::AttachmentBrokerPrivileged::UMAError.
On 2016/03/11 00:29:04, Anand Mistry wrote:
> On 2016/03/10 17:54:09, erikchen wrote:
> > Use an enum here, and have IPC::AttachmentBrokerPrivileged do the conversion
> > from this enum to the UMA values..
> 
> Is this what you had in mind?

yup. still lgtm.

[Anand Mistry (off Chromium), 2016-03-11 00:59:42]

amistry@chromium.org changed reviewers:
+ tsepez@chromium.org

[Anand Mistry (off Chromium), 2016-03-11 00:59:42]

tsepez@chromium.org: //ipc OWNERS

[Tom Sepez, 2016-03-11 17:46:46]

lgtm

[Anand Mistry (off Chromium), 2016-03-11 23:42:31]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2016-03-11 23:42:32]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/1778203002/#ps60001
(title: "enum for error code")

[commit-bot: I haz the power, 2016-03-11 23:43:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778203002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778203002/60001

[commit-bot: I haz the power, 2016-03-12 04:51:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-12 04:54:01]

Description was changed from

==========
Move mach code shared by Chrome IPC and Mojo to //base/mac.

BUG=582468
==========

to

==========
Move mach code shared by Chrome IPC and Mojo to //base/mac.

BUG=582468

Committed: https://crrev.com/e04cef7c43dc8c9562f41e3fc51fef73f48da05a
Cr-Commit-Position: refs/heads/master@{#380855}
==========

[commit-bot: I haz the power, 2016-03-12 04:54:01]

Patchset 4 (id:??) landed as
https://crrev.com/e04cef7c43dc8c9562f41e3fc51fef73f48da05a
Cr-Commit-Position: refs/heads/master@{#380855}