appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py - Issue 1778153002: [Findit] Strip platform from step_name before triggering try job.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py

Issue 1778153002: [Findit] Strip platform from step_name before triggering try job. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: . Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/test/run_try_job_for_reliable_failure_pipeline_test.py ('k') | appengine/findit/waterfall/trigger_swarming_task_pipeline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py b/appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py

index 6df1035075ff3cba973072266a270c1539f614f5..1de3e6e0f4bb5718349cc949b43df34a5d96716c 100644

--- a/appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py

+++ b/appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py

@@ -111,7 +111,7 @@ class TriggerSwarmingTaskPipelineTest(testing.AppengineTestCase):

'inputs_ref': {'a': 1},

'io_timeout_secs': 1200,

- 'tags': ['master:a', 'buildername:b'],

+ 'tags': ['master:a', 'buildername:b', 'name:a_tests'],

'user': 'user',

})

self.mock(swarming_util, 'GetSwarmingTaskRequest',

@@ -133,7 +133,7 @@ class TriggerSwarmingTaskPipelineTest(testing.AppengineTestCase):

master_name = 'm'

builder_name = 'b'

build_number = 234

- step_name = 's'

+ step_name = 'a_tests on platform'

tests = ['a.b', 'a.c']

expected_new_request_json = {

@@ -161,7 +161,8 @@ class TriggerSwarmingTaskPipelineTest(testing.AppengineTestCase):

'ref_buildername:%s' % builder_name,

'ref_buildnumber:%s' % build_number,

'ref_stepname:%s' % step_name,

- 'ref_task_id:1'],

+ 'ref_task_id:1',

+ 'ref_name:a_tests'],

'user': '',

}