appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py - Issue 1778153002: [Findit] Strip platform from step_name before triggering try job.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py

Issue 1778153002: [Findit] Strip platform from step_name before triggering try job. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: . Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/process_swarming_task_result_pipeline.py ('k') | appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py

diff --git a/appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py b/appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py

index 8cb30df270d80bc85b7506b6067994c65a9f1b15..3c9e38238ed8e1137c3dd414cefc9beeee17f389 100644

--- a/appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py

+++ b/appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py

@@ -26,10 +26,12 @@ def _GetReliableTargetedTests(targeted_tests, classified_tests_by_step):

# If the step is swarming but there is no result for it, it's highly

# likely that there is some error with the task.

# Thus skip this step for no insights from task to avoid false positive.

- classified_tests = classified_tests_by_step[step_name]

+ step_name_no_platform = classified_tests_by_step[step_name][0]

+ classified_tests = classified_tests_by_step[step_name][1]

for test in tests:

if (test in classified_tests.get('reliable_tests', [])):

- reliable_tests[step_name].append(test)

+ reliable_tests[step_name_no_platform].append(test)

else: # Non-swarming step, includes it directly.

reliable_tests[step_name] = []

return reliable_tests