Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

Issue 1778153002: [Findit] Strip platform from step_name before triggering try job. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from pipeline_wrapper import BasePipeline 5 from pipeline_wrapper import BasePipeline
6 from waterfall.process_swarming_task_result_pipeline import ( 6 from waterfall.process_swarming_task_result_pipeline import (
7 ProcessSwarmingTaskResultPipeline) 7 ProcessSwarmingTaskResultPipeline)
8 from waterfall.run_try_job_for_reliable_failure_pipeline import ( 8 from waterfall.run_try_job_for_reliable_failure_pipeline import (
9 RunTryJobForReliableFailurePipeline) 9 RunTryJobForReliableFailurePipeline)
10 from waterfall.trigger_swarming_task_pipeline import TriggerSwarmingTaskPipeline 10 from waterfall.trigger_swarming_task_pipeline import TriggerSwarmingTaskPipeline
(...skipping 14 matching lines...) Expand all
25 # The format would be [('step1', {'flaky_tests': ['test1', ..], ..}), ..] 25 # The format would be [('step1', {'flaky_tests': ['test1', ..], ..}), ..]
26 classified_tests_by_step = [] 26 classified_tests_by_step = []
27 27
28 if try_job_type == TryJobType.TEST: 28 if try_job_type == TryJobType.TEST:
29 for step_name, tests in targeted_tests.iteritems(): 29 for step_name, tests in targeted_tests.iteritems():
30 if not tests: # Skip non-swarming tests. 30 if not tests: # Skip non-swarming tests.
31 continue 31 continue
32 task_id = yield TriggerSwarmingTaskPipeline( 32 task_id = yield TriggerSwarmingTaskPipeline(
33 master_name, builder_name, build_number, step_name, tests) 33 master_name, builder_name, build_number, step_name, tests)
34 step_future = yield ProcessSwarmingTaskResultPipeline( 34 step_future = yield ProcessSwarmingTaskResultPipeline(
35 master_name, builder_name, build_number, step_name, task_id) 35 master_name, builder_name, build_number, step_name,
36 task_id)
stgao 2016/03/10 23:50:28 Could be reverted?
chanli 2016/03/11 00:49:41 Missed... Done
36 classified_tests_by_step.append(step_future) 37 classified_tests_by_step.append(step_future)
37 38
38 # Waits until classified_tests_by_step are ready. 39 # Waits until classified_tests_by_step are ready.
39 yield RunTryJobForReliableFailurePipeline( 40 yield RunTryJobForReliableFailurePipeline(
40 master_name, builder_name, build_number, good_revision, 41 master_name, builder_name, build_number, good_revision,
41 bad_revision, blame_list, try_job_type, compile_targets, targeted_tests, 42 bad_revision, blame_list, try_job_type, compile_targets, targeted_tests,
42 *classified_tests_by_step) 43 *classified_tests_by_step)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698