[Findit] Strip platform from step_name before triggering try job.

appengine/findit/waterfall/process_swarming_task_result_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import datetime
 import logging
 import time
 
 from common.http_client_appengine import HttpClientAppengine as HttpClient
@@ skipping 67 matching lines @@
     assert task_id
     timeout_hours = waterfall_config.GetSwarmingSettings().get(
         'task_timeout_hours')
     deadline = time.time() + timeout_hours * 60 * 60
     server_query_interval_seconds = waterfall_config.GetSwarmingSettings().get(
         'server_query_interval_seconds')
 
     task_started = False
     task_completed = False
     tests_statuses = {}
+    step_name_no_platform = step_name

[stgao, 2016/03/10 23:50:28]

Should not default to step name for steps running on Swarming.

[chanli, 2016/03/11 00:49:41]

I think we need to fall back to step name just in case.

[stgao, 2016/03/11 01:03:20]

In which scenario do you think we need to fall back to step name?

[chanli, 2016/03/11 03:47:00]

Just for precaution. 

[stgao, 2016/03/11 06:42:58]

But the step names always includes the platform name now. That won't work.

 
     while not task_completed:
       # Keeps monitoring the swarming task, waits for it to complete.
       data = swarming_util.GetSwarmingTaskResultById(
           task_id, self.HTTP_CLIENT)
       task_state = data['state']
+      step_name_no_platform = swarming_util.GetTagValue(
+          data.get('tags', {}), 'ref_name') or step_name
       if task_state not in swarming_util.STATES_RUNNING:
         task_completed = True
         task = WfSwarmingTask.Get(
             master_name, builder_name, build_number, step_name)
         if task_state == swarming_util.STATE_COMPLETED:
           outputs_ref = data.get('outputs_ref')
           output_json = swarming_util.GetSwarmingTaskFailureLog(
               outputs_ref, self.HTTP_CLIENT)
           tests_statuses = _CheckTestsRunStatuses(output_json)
 
@@ skipping 29 matching lines @@
         break  # Stops the loop and return.
 
     # Update swarming task metadate.
     task = WfSwarmingTask.Get(
         master_name, builder_name, build_number, step_name)
     task.created_time = _ConvertDateTime(data.get('created_ts'))
     task.started_time = _ConvertDateTime(data.get('started_ts'))
     task.completed_time = _ConvertDateTime(data.get('completed_ts'))
     task.put()
 
-    return step_name, task.classified_tests
+    return step_name, (step_name_no_platform, task.classified_tests)