|
|
Created:
4 years, 9 months ago by hal.canary Modified:
4 years, 9 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionpdf_metafile_skia: set metadata before drawing to pdf
Motivation: while experimenting with serializing images immediately,
we would like to keep serializing metadata first.
Committed: https://crrev.com/0aeeb333aba5c8cc43fe0b9b8a8469f81d9cde7a
Cr-Commit-Position: refs/heads/master@{#381959}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
halcanary@google.com changed reviewers: + djsollen@google.com, vitalybuka@chromium.org
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778133005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778133005/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== pdf_metafile_skia: set metadata before drawing to pdf ========== to ========== pdf_metafile_skia: set metadata before drawing to pdf Motivation: while experimenting with serializing images immediately, we would like to keep serializing metadata first. ==========
please take a look.
vitalybuka@chromium.org changed reviewers: + thestig@chromium.org
lgtm
halcanary@google.com changed reviewers: + tomhudson@chromium.org
adding tom to review.
tomhudson@google.com changed reviewers: + tomhudson@google.com
lgtm
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778133005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778133005/1
Message was sent while issue was closed.
Description was changed from ========== pdf_metafile_skia: set metadata before drawing to pdf Motivation: while experimenting with serializing images immediately, we would like to keep serializing metadata first. ========== to ========== pdf_metafile_skia: set metadata before drawing to pdf Motivation: while experimenting with serializing images immediately, we would like to keep serializing metadata first. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== pdf_metafile_skia: set metadata before drawing to pdf Motivation: while experimenting with serializing images immediately, we would like to keep serializing metadata first. ========== to ========== pdf_metafile_skia: set metadata before drawing to pdf Motivation: while experimenting with serializing images immediately, we would like to keep serializing metadata first. Committed: https://crrev.com/0aeeb333aba5c8cc43fe0b9b8a8469f81d9cde7a Cr-Commit-Position: refs/heads/master@{#381959} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0aeeb333aba5c8cc43fe0b9b8a8469f81d9cde7a Cr-Commit-Position: refs/heads/master@{#381959} |