Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1778133005: pdf_metafile_skia: set metadata before drawing to pdf (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

pdf_metafile_skia: set metadata before drawing to pdf Motivation: while experimenting with serializing images immediately, we would like to keep serializing metadata first. Committed: https://crrev.com/0aeeb333aba5c8cc43fe0b9b8a8469f81d9cde7a Cr-Commit-Position: refs/heads/master@{#381959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M printing/pdf_metafile_skia.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778133005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778133005/1
4 years, 9 months ago (2016-03-10 21:55:59 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/194918)
4 years, 9 months ago (2016-03-10 22:30:34 UTC) #5
hal.canary
please take a look.
4 years, 9 months ago (2016-03-11 15:50:16 UTC) #7
Vitaly Buka (NO REVIEWS)
lgtm
4 years, 9 months ago (2016-03-11 19:13:50 UTC) #9
hal.canary
adding tom to review.
4 years, 9 months ago (2016-03-17 22:07:12 UTC) #11
tomhudson
lgtm
4 years, 9 months ago (2016-03-18 13:25:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778133005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778133005/1
4 years, 9 months ago (2016-03-18 13:27:46 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 14:32:49 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 14:33:56 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0aeeb333aba5c8cc43fe0b9b8a8469f81d9cde7a
Cr-Commit-Position: refs/heads/master@{#381959}

Powered by Google App Engine
This is Rietveld 408576698