Issue 17781002: Allow users of the V8 API to distinguish between unset and undefined HiddenValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17781002: Allow users of the V8 API to distinguish between unset and undefined HiddenValues (Closed)

Created:
7 years, 6 months ago by adamk

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev, jww

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Allow users of the V8 API to distinguish between unset and undefined HiddenValues BUG=v8:2746 R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15329

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -6 lines)			Patch
M	src/api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

adamk

It's not clear to me if this was intended behavior for some reason; if it ...

7 years, 6 months ago (2013-06-26 02:52:26 UTC) #1

Sven Panne

LGTM. To be honest, I don't see a reason why these 2 cases were mapped ...

7 years, 6 months ago (2013-06-26 07:57:58 UTC) #2

Sven Panne

7 years, 6 months ago (2013-06-26 08:00:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15329 (presubmit successful).