Enforce users to specify a 'pool' dimension when triggering a task.

Enforce users to specify a 'pool' dimension when triggering a task.

By default, the 'pool' bot dimensions is set to 'default'. The goal is to catch
misconfigured clients. I would have preferred 'project' but 'pool' should be
good enough.

This will break projects but will fix issues like
https://bugs.chromium.org/p/chromium/issues/detail?id=591767.

This means that a previous task that wouldn't have specified a pool can't be
retried once this code is live.

R=vadimsh@chromium.org
BUG=

Committed: https://github.com/luci/luci-py/commit/1c349ee464a4a1d1ee2ccff81ab0ce06436e6e19

[M-A Ruel, 2016-03-09 20:48:03]

Description was changed from

==========
Enforce users to specify a 'pool' dimension when triggering a task.

By default, the 'pool' bot dimensions is set to 'default'. The goal is to catch
misconfigured clients. I would have preferred 'project' but 'pool' should be
good enough.

This will break projects but will fix issues like
https://bugs.chromium.org/p/chromium/issues/detail?id=591767.

This means that a previous task that wouldn't have specified a pool can't be
retried once this code is live.

R=vadimsh@chromium.org
BUG=
==========

to

==========
Enforce users to specify a 'pool' dimension when triggering a task.

By default, the 'pool' bot dimensions is set to 'default'. The goal is to catch
misconfigured clients. I would have preferred 'project' but 'pool' should be
good enough.

This will break projects but will fix issues like
https://bugs.chromium.org/p/chromium/issues/detail?id=591767.

This means that a previous task that wouldn't have specified a pool can't be
retried once this code is live.

R=vadimsh@chromium.org
BUG=
==========

[M-A Ruel, 2016-03-09 20:49:19]

THIS IS A BREAKING CHANGE if and ONLY if your task didn't consistently specify a
'pool' dimension.

I want to enforce it to diminish the risk of tasks running on the wrong pool.

[Vadim Sh., 2016-03-09 20:54:47]

lgtm

good luck updating all swarming instances...

[M-A Ruel, 2016-04-13 22:07:11]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2016-04-13 22:07:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778083002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778083002/1

[commit-bot: I haz the power, 2016-04-13 22:10:56]

Description was changed from

==========
Enforce users to specify a 'pool' dimension when triggering a task.

By default, the 'pool' bot dimensions is set to 'default'. The goal is to catch
misconfigured clients. I would have preferred 'project' but 'pool' should be
good enough.

This will break projects but will fix issues like
https://bugs.chromium.org/p/chromium/issues/detail?id=591767.

This means that a previous task that wouldn't have specified a pool can't be
retried once this code is live.

R=vadimsh@chromium.org
BUG=
==========

to

==========
Enforce users to specify a 'pool' dimension when triggering a task.

By default, the 'pool' bot dimensions is set to 'default'. The goal is to catch
misconfigured clients. I would have preferred 'project' but 'pool' should be
good enough.

This will break projects but will fix issues like
https://bugs.chromium.org/p/chromium/issues/detail?id=591767.

This means that a previous task that wouldn't have specified a pool can't be
retried once this code is live.

R=vadimsh@chromium.org
BUG=

Committed:
https://github.com/luci/luci-py/commit/1c349ee464a4a1d1ee2ccff81ab0ce06436e6e19
==========

[commit-bot: I haz the power, 2016-04-13 22:10:57]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/1c349ee464a4a1d1ee2ccff81ab0ce06436e6e19