Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1778073003: Add option in Makefile to preserve frame pointer. (Closed)

Created:
4 years, 9 months ago by Stefano Sanfilippo
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add option in Makefile to preserve frame pointer. LOG=N Committed: https://crrev.com/8136372a46108264b6aebaffccfafdb8c4a3a983 Cr-Commit-Position: refs/heads/master@{#34670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Makefile View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Stefano Sanfilippo
We need this option for profiling release builds. PTAL.
4 years, 9 months ago (2016-03-10 10:38:23 UTC) #2
Michael Achenbach
lgtm
4 years, 9 months ago (2016-03-10 11:57:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778073003/1
4 years, 9 months ago (2016-03-10 12:27:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 12:59:31 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 12:59:59 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8136372a46108264b6aebaffccfafdb8c4a3a983
Cr-Commit-Position: refs/heads/master@{#34670}

Powered by Google App Engine
This is Rietveld 408576698