Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: runtime/bin/eventhandler_win.cc

Issue 177803002: Remove non-fatal prints from windows eventhandler. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler_win.cc
diff --git a/runtime/bin/eventhandler_win.cc b/runtime/bin/eventhandler_win.cc
index 1fdbe204b72af65900b1ac2ed7fa0b0ef1f2540f..534f3284e2e4648195d71dffafd6eb42e8c184d6 100644
--- a/runtime/bin/eventhandler_win.cc
+++ b/runtime/bin/eventhandler_win.cc
@@ -160,7 +160,6 @@ bool Handle::CreateCompletionPort(HANDLE completion_port) {
reinterpret_cast<ULONG_PTR>(this),
0);
if (completion_port_ == NULL) {
- Log::PrintErr("Error CreateIoCompletionPort: %d\n", GetLastError());
return false;
}
return true;
@@ -247,9 +246,6 @@ void Handle::ReadSyncCompleteAsync() {
&bytes_read,
NULL);
if (!ok) {
- if (GetLastError() != ERROR_BROKEN_PIPE) {
- Log::PrintErr("ReadFile failed %d\n", GetLastError());
- }
bytes_read = 0;
}
OVERLAPPED* overlapped = pending_read_->GetCleanOverlapped();
@@ -423,7 +419,6 @@ bool ListenSocket::LoadAcceptEx() {
NULL,
NULL);
if (status == SOCKET_ERROR) {
- Log::PrintErr("Error WSAIoctl failed: %d\n", WSAGetLastError());
return false;
}
return true;
@@ -491,7 +486,6 @@ void ListenSocket::AcceptComplete(OverlappedBuffer* buffer,
accepted_tail_ = client_socket;
}
} else {
- Log::PrintErr("setsockopt failed: %d\n", WSAGetLastError());
closesocket(buffer->client());
}
} else {
@@ -667,9 +661,6 @@ void StdHandle::WriteSyncCompleteAsync() {
&bytes_written,
NULL);
if (!ok) {
- if (GetLastError() != ERROR_BROKEN_PIPE) {
- Log::PrintErr("WriteFile failed %d\n", GetLastError());
- }
bytes_written = 0;
}
thread_wrote_ += bytes_written;
@@ -745,7 +736,6 @@ bool ClientSocket::LoadDisconnectEx() {
NULL,
NULL);
if (status == SOCKET_ERROR) {
- Log::PrintErr("Error WSAIoctl failed: %d\n", WSAGetLastError());
return false;
}
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698