Issue 17780002: Rewrite scoped_ptr<T>(NULL) to use the default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17780002: Rewrite scoped_ptr<T>(NULL) to use the default ctor. (Closed)

Created:
7 years, 6 months ago by dcheng

Modified:
7 years, 6 months ago

Reviewers:
rlarocque, Yaron

CC:
chromium-reviews, tim+watch_chromium.org, craigdh+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor. This is a manual cleanup of call sites that invoke scoped_ptr<T>'s constructor with an explicit NULL argument that are only built on Android. BUG=173286 R=rlarocque@chromium.org, yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208730

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -4 lines)			Patch
M	base/android/activity_status_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_android.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/android/forwarder2/daemon.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dcheng

7 years, 6 months ago (2013-06-26 18:01:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r208730 (presubmit successful).

Expand Messages | Collapse Messages