Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1777923002: SkPDF: use sk_ref_sp (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/doc/SkDocument_PDF.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFFormXObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFResourceDict.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFShader.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
hal.canary
please ruberstamp
4 years, 9 months ago (2016-03-09 15:29:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777923002/1
4 years, 9 months ago (2016-03-09 15:35:55 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-09 15:35:56 UTC) #7
bungeman-skia
lgtm with the proviso that we're still actively working to remove these uses.
4 years, 9 months ago (2016-03-09 15:49:46 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 15:52:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e94ea625fbce6979b7ef59255c7598e81d37f546

Powered by Google App Engine
This is Rietveld 408576698