Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1777913003: extract resource path test utils (Closed)

Created:
4 years, 9 months ago by danrubel
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -113 lines) Patch
A pkg/analyzer/test/resource_utils.dart View 1 chunk +130 lines, -0 lines 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 2 chunks +1 line, -113 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
4 years, 9 months ago (2016-03-09 21:19:53 UTC) #2
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-09 21:22:27 UTC) #3
danrubel
4 years, 9 months ago (2016-03-09 21:25:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14983f0a26b701fb419e2cd588cc4e44f590a2a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698