Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1777913002: [x64] Fix crashes in CheckAccessGlobalProxy (Closed)

Created:
4 years, 9 months ago by Jakob Kummerow
Modified:
4 years, 9 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Fix crashes in CheckAccessGlobalProxy We have to do a Smi check on the frame marker, not just compare against a single frame type. BUG=chromium:593332 LOG=n TBR=danno@chromium.org Committed: https://crrev.com/592ad6dce1d5ebf8227f48c409c4d4ff2403cdad Cr-Commit-Position: refs/heads/master@{#34625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/x64/macro-assembler-x64.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777913002/1
4 years, 9 months ago (2016-03-09 14:52:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 15:13:59 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 15:15:19 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/592ad6dce1d5ebf8227f48c409c4d4ff2403cdad
Cr-Commit-Position: refs/heads/master@{#34625}

Powered by Google App Engine
This is Rietveld 408576698