Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1777903003: Ensure the NavigationHandle's nav entry ID is updated during transfers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix else branch Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index d99018945366b5feda09daea5fd64f3ce9334497..12a5dcc3c2de7a50f96b53d4fb2ccca1eb878014 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -296,6 +296,10 @@ RenderFrameHostImpl* RenderFrameHostManager::Navigate(
// The navigating RenderFrameHost should take ownership of the
// NavigationHandle that came from the transferring RenderFrameHost.
DCHECK(transfer_navigation_handle_);
+ // Update the pending NavigationEntry ID on the handle as well.
nasko 2016/03/11 17:10:06 nit: Empty line before the comment makes it a bit
Charlie Reis 2016/03/11 20:12:48 Done.
+ // TODO(creis): Make this line unnecessary by avoiding having a pending
+ // entry for transfer navigations. See https://crbug.com/495161.
+ transfer_navigation_handle_->set_pending_nav_entry_id(entry.GetUniqueID());
dest_render_frame_host->SetNavigationHandle(
std::move(transfer_navigation_handle_));
}

Powered by Google App Engine
This is Rietveld 408576698