content/browser/frame_host/navigation_controller_impl.h - Issue 1777903003: Ensure the NavigationHandle's nav entry ID is updated during transfers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 1777903003: Ensure the NavigationHandle's nav entry ID is updated during transfers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move fix to another CL (now cleanup only) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/cross_site_transfer_browsertest.cc ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl.h

diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h

index deb6db483e4f6f200801220237bbe60dc0f322f3..9b0e6dcb5bf434b4896d719c916afb1d473f8fc3 100644

--- a/content/browser/frame_host/navigation_controller_impl.h

+++ b/content/browser/frame_host/navigation_controller_impl.h

@@ -258,6 +258,10 @@ class CONTENT_EXPORT NavigationControllerImpl

FrameLoadVector* sameDocumentLoads,

FrameLoadVector* differentDocumentLoads);

+ // Returns whether there is a pending NavigationEntry whose unique ID matches

+ // the given NavigationHandle's pending_nav_entry_id.

+ bool PendingEntryMatchesHandle(NavigationHandleImpl* handle) const;

// Classifies the given renderer navigation (see the NavigationType enum).

NavigationType ClassifyNavigation(

RenderFrameHostImpl* rfh,