Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1777853002:
Version 5.0.71.11 (cherry-pick) (Closed)
|
Created:
4 years, 9 months ago by zhengxing.li Modified:
4 years, 9 months ago Reviewers:
Michael Hablich CC:
v8-reviews_googlegroups.com, ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0 Target Ref:
refs/pending/branch-heads/5.0 Project:
v8 Visibility:
Public. |
DescriptionVersion 5.0.71.11 (cherry-pick)
Merged 1736ad786ff96212fe452acb793b9543ca154da6
X87: [proxies] throw TypeError if is_callable Map bit is unset.
R=hablich@chromium.org
BUG=v8:1543, v8:4796, v8:4797
LOG=N
NOTRY=true
NOPRESUBMIT=true
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Version 5.0.71.11 (cherry-pick) Merged 1736ad786ff96212fe452acb793b9543ca154da6 X87: [proxies] throw TypeError if is_callable Map bit is unset. R=hablich@chromium.org BUG= ========== to ========== Version 5.0.71.11 (cherry-pick) Merged 1736ad786ff96212fe452acb793b9543ca154da6 X87: [proxies] throw TypeError if is_callable Map bit is unset. R=hablich@chromium.org BUG=v8:1543,v8:4796,v8:4797 LOG=N ==========
On 2016/03/09 07:52:33, zhengxing.li wrote: lgtm Please make sure to always include the associated bug. I edited the description for this one already.
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777853002/1
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
On 2016/03/09 08:11:38, Hablich wrote: > On 2016/03/09 07:52:33, zhengxing.li wrote: > > lgtm > > Please make sure to always include the associated bug. I edited the description > for this one already. Got it. Thank you very much, Michael!
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777853002/1
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== Version 5.0.71.11 (cherry-pick) Merged 1736ad786ff96212fe452acb793b9543ca154da6 X87: [proxies] throw TypeError if is_callable Map bit is unset. R=hablich@chromium.org BUG=v8:1543,v8:4796,v8:4797 LOG=N ========== to ========== Version 5.0.71.11 (cherry-pick) Merged 1736ad786ff96212fe452acb793b9543ca154da6 X87: [proxies] throw TypeError if is_callable Map bit is unset. R=hablich@chromium.org BUG=v8:1543,v8:4796,v8:4797 LOG=N NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777853002/1
Message was sent while issue was closed.
Description was changed from ========== Version 5.0.71.11 (cherry-pick) Merged 1736ad786ff96212fe452acb793b9543ca154da6 X87: [proxies] throw TypeError if is_callable Map bit is unset. R=hablich@chromium.org BUG=v8:1543,v8:4796,v8:4797 LOG=N NOTRY=true NOPRESUBMIT=true ========== to ========== Version 5.0.71.11 (cherry-pick) Merged 1736ad786ff96212fe452acb793b9543ca154da6 X87: [proxies] throw TypeError if is_callable Map bit is unset. R=hablich@chromium.org BUG=v8:1543,v8:4796,v8:4797 LOG=N NOTRY=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
