Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1777823002: Create map for dump_info on demand. (Closed)

Created:
4 years, 9 months ago by sra1
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create map for dump_info on demand. Saves about 1% of heap for non --dump-info compile. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/42070892a4c36941369db891d3e7a74c851c011b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 5 (2 generated)
sra1
This comes from your send-stats CL.
4 years, 9 months ago (2016-03-09 04:46:35 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1777823002/diff/1/pkg/compiler/lib/src/resolution/tree_elements.dart File pkg/compiler/lib/src/resolution/tree_elements.dart (right): https://codereview.chromium.org/1777823002/diff/1/pkg/compiler/lib/src/resolution/tree_elements.dart#newcode117 pkg/compiler/lib/src/resolution/tree_elements.dart:117: _typesCache ?? _typesCache = <Node, DartType>{}; replace with ...
4 years, 9 months ago (2016-03-09 19:15:03 UTC) #3
sra1
4 years, 9 months ago (2016-03-09 21:15:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
42070892a4c36941369db891d3e7a74c851c011b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698