Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1777813002: MD - use new style of text button in infobars. (Closed)

Created:
4 years, 9 months ago by Evan Stade
Modified:
4 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD - use new style of text button in infobars. BUG=520266 Committed: https://crrev.com/d034150c37234dfa2eedf8fde15f9fedd8c3cd10 Cr-Commit-Position: refs/heads/master@{#380410}

Patch Set 1 #

Total comments: 2

Patch Set 2 : uac button cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -53 lines) Patch
M chrome/browser/ui/views/infobars/confirm_infobar.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/confirm_infobar.cc View 1 2 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.h View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 2 chunks +28 lines, -32 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Evan Stade
4 years, 9 months ago (2016-03-09 03:48:50 UTC) #2
Peter Kasting
https://codereview.chromium.org/1777813002/diff/1/chrome/browser/ui/views/infobars/confirm_infobar.cc File chrome/browser/ui/views/infobars/confirm_infobar.cc (right): https://codereview.chromium.org/1777813002/diff/1/chrome/browser/ui/views/infobars/confirm_infobar.cc#newcode74 chrome/browser/ui/views/infobars/confirm_infobar.cc:74: // Use a label button even in MD mode ...
4 years, 9 months ago (2016-03-09 07:18:10 UTC) #3
Evan Stade
https://codereview.chromium.org/1777813002/diff/1/chrome/browser/ui/views/infobars/confirm_infobar.cc File chrome/browser/ui/views/infobars/confirm_infobar.cc (right): https://codereview.chromium.org/1777813002/diff/1/chrome/browser/ui/views/infobars/confirm_infobar.cc#newcode74 chrome/browser/ui/views/infobars/confirm_infobar.cc:74: // Use a label button even in MD mode ...
4 years, 9 months ago (2016-03-10 02:41:42 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777813002/20001
4 years, 9 months ago (2016-03-10 02:42:09 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 03:50:53 UTC) #8
Peter Kasting
LGTM
4 years, 9 months ago (2016-03-10 04:41:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777813002/20001
4 years, 9 months ago (2016-03-10 15:23:14 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 15:28:04 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 15:29:15 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d034150c37234dfa2eedf8fde15f9fedd8c3cd10
Cr-Commit-Position: refs/heads/master@{#380410}

Powered by Google App Engine
This is Rietveld 408576698