Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1777793003: Revert of clang upload.sh: don't download Clang binaries from clang_upload bots. (Closed)

Created:
4 years, 9 months ago by krasin1
Modified:
4 years, 9 months ago
Reviewers:
hans, Nico, krasin
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org, kcc2, pcc1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of clang upload.sh: don't download Clang binaries from clang_upload bots. (patchset #3 id:40001 of https://codereview.chromium.org/1757733004/ ) Reason for revert: Not needed anymore. https://codereview.chromium.org/1776893002/ was a better approach. Original issue's description: > clang upload.sh: don't download Clang binaries from clang_upload bots. > > Clang Upload trybots are used to build the new Clang > binaries. Right now, they fail, because they try to download > the not-yet-built clang revision during runhooks. > > In this CL a check into update.py is added to skip the > download if it's running from Clang Upload trybot. LLVM_FORCE_LOCAL_BUILD env var is used for that. > > BUG=578306 > > Committed: https://crrev.com/9321234d5ec76fadeacefd38591b93420dc62b67 > Cr-Commit-Position: refs/heads/master@{#379989} TBR=thakis@chromium.org,hans@chromium.org,krasin@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=578306 Committed: https://crrev.com/729a518e05c01b45067d28c9eebfb05ef76043ff Cr-Commit-Position: refs/heads/master@{#380072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
krasin1
Created Revert of clang upload.sh: don't download Clang binaries from clang_upload bots.
4 years, 9 months ago (2016-03-09 05:06:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777793003/1
4 years, 9 months ago (2016-03-09 05:06:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 05:07:20 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 05:08:29 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/729a518e05c01b45067d28c9eebfb05ef76043ff
Cr-Commit-Position: refs/heads/master@{#380072}

Powered by Google App Engine
This is Rietveld 408576698