[display] Refactor to avoid implicit framebuffer allocation.

target/dartuinoP0/display/memory_lcd_mono.c

 /*
  * Copyright (c) 2016 Craig Stout <cstout@chromium.org>
  *
  * Permission is hereby granted, free of charge, to any person obtaining
  * a copy of this software and associated documentation files
  * (the "Software"), to deal in the Software without restriction,
  * including without limitation the rights to use, copy, modify, merge,
  * publish, distribute, sublicense, and/or sell copies of the Software,
  * and to permit persons to whom the Software is furnished to do so,
  * subject to the following conditions:
@@ skipping 14 matching lines @@
 #include <target/display/LS027B7DH01.h>
 #elif defined (LCD_LS013B7DH03)
 #include <target/display/LS013B7DH03.h>
 #else
 #error Undefined display header
 #endif
 
 #include <string.h>
 #include <assert.h>
 
-#define SET_BIT(BUF, BITNUM) ((BUF)[(BITNUM) >> 3] |= (0xff & (0x1 << ((BITNUM) & 0x07))))
+#define SET_BIT(BUF, BITNUM) ((BUF)[(BITNUM) >> 3] |= (0x1 << ((BITNUM) & 0x07)))
 
-uint8_t lcd_get_line(uint8_t *framebuffer, uint8_t idx, uint8_t *result)
+uint8_t lcd_get_line(struct display_image *image, uint8_t idx, uint8_t *result)
 {
-    framebuffer += FB_STRIDE * idx;
+    uint8_t *framebuffer = (uint8_t *) image->pixels + image->rowbytes * idx;
 
-#if FB_FORMAT == DISPLAY_FORMAT_MONO_1
-    memcpy(result, framebuffer, MLCD_BYTES_LINE);
-
-#elif FB_FORMAT == DISPLAY_FORMAT_MONO_8
-    memset(result, 0, MLCD_BYTES_LINE);
-    for (uint i = 0; i < MLCD_WIDTH; ++i) {
-        if (framebuffer[i] > 128) {
-            SET_BIT(result, i);
+    if (image->format == IMAGE_FORMAT_MONO_1) {
+        memcpy(result, framebuffer, MLCD_BYTES_LINE);
+    } else if (image->format == IMAGE_FORMAT_MONO_8) {
+        memset(result, 0, MLCD_BYTES_LINE);
+        for (uint i = 0; i < MLCD_WIDTH; ++i) {
+            if (framebuffer[i] > 128) {
+                SET_BIT(result, i);
+            }
         }
+    } else {
+        DEBUG_ASSERT(false);
     }
-
-#else
-#error Unhandled FB_FORMAT
-#endif
-
     return MLCD_BYTES_LINE;
 }