[display] Refactor to avoid implicit framebuffer allocation.

dev/virtio/gpu/virtio-gpu.c

 /*
  * Copyright (c) 2014-2015 Travis Geiselbrecht
  *
  * Permission is hereby granted, free of charge, to any person obtaining
  * a copy of this software and associated documentation files
  * (the "Software"), to deal in the Software without restriction,
  * including without limitation the rights to use, copy, modify, merge,
  * publish, distribute, sublicense, and/or sell copies of the Software,
  * and to permit persons to whom the Software is furnished to do so,
  * subject to the following conditions:
@@ skipping 15 matching lines @@
 #include <assert.h>
 #include <trace.h>
 #include <compiler.h>
 #include <list.h>
 #include <err.h>
 #include <string.h>
 #include <kernel/thread.h>
 #include <kernel/event.h>
 #include <kernel/mutex.h>
 #include <kernel/vm.h>
-#include <lib/gfx.h>
 #include <dev/display.h>
 
 #include "virtio_gpu.h"
 
 #define LOCAL_TRACE 0
 
 static enum handler_return virtio_gpu_irq_driver_callback(struct virtio_device *dev, uint ring, const struct vring_used_elem *e);
 static enum handler_return virtio_gpu_config_change_callback(struct virtio_device *dev);
 static int virtio_gpu_flush_thread(void *arg);
 
@@ skipping 503 matching lines @@
     }
 
     return 0;
 }
 
 void virtio_gpu_gfx_flush(uint starty, uint endy)
 {
     event_signal(&the_gdev->flush_event, !arch_ints_disabled());
 }
 
+status_t display_get_framebuffer(struct display_framebuffer *fb)
+{

[gkalsi, 2016/03/09 21:13:37]

nit: DEBUG_ASSERT(fb);

[cdotstout, 2016/03/09 22:48:00]

Done.

+    memset(fb, 0, sizeof(*fb));
+
+    if (!the_gdev)
+        return ERR_NOT_FOUND;
+
+    fb->image.pixels = the_gdev->fb;
+    fb->image.format = IMAGE_FORMAT_RGB_x888;
+    fb->image.width = the_gdev->pmode.r.width;
+    fb->image.height = the_gdev->pmode.r.height;
+    fb->image.rowbytes = fb->image.width;
+    fb->flush = virtio_gpu_gfx_flush;
+    fb->format = DISPLAY_FORMAT_RGB_x888;
+
+    return NO_ERROR;
+}
+
 status_t display_get_info(struct display_info *info)

[gkalsi, 2016/03/09 21:13:37]

nit: DEBUG_ASSERT(info);

[cdotstout, 2016/03/09 22:47:59]

Done.

 {
     memset(info, 0, sizeof(*info));
 
     if (!the_gdev)
         return ERR_NOT_FOUND;
 
-    info->framebuffer = the_gdev->fb;
-    info->format = GFX_FORMAT_RGB_x888;
+    info->format = DISPLAY_FORMAT_RGB_x888;
     info->width = the_gdev->pmode.r.width;
     info->height = the_gdev->pmode.r.height;
-    info->stride = info->width;
-    info->flush = virtio_gpu_gfx_flush;
 
     return NO_ERROR;
 }
-
-