Source/bindings/v8/custom/V8PromiseCustom.h - Issue 177773002: Support Promises instrumentation on backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8PromiseCustom.h

Issue 177773002: Support Promises instrumentation on backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: V8PromiseCustom::setState -> (anonymous namespace)::setStateForPromise + REBASE Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8PromiseCustom.h

diff --git a/Source/bindings/v8/custom/V8PromiseCustom.h b/Source/bindings/v8/custom/V8PromiseCustom.h

index b6ba31c03e66fe4267c30f037976d5cc7a0cc3b6..17d71280a4db491953ba12f4e6c38445bb13422e 100644

--- a/Source/bindings/v8/custom/V8PromiseCustom.h

+++ b/Source/bindings/v8/custom/V8PromiseCustom.h

@@ -70,10 +70,6 @@ public:

// |internal| must be a Promise internal object.

static PromiseState getState(v8::Handle<v8::Object> internal);

- // |internal| must be a Promise internal object.

- // Set a |promise|'s state and result that correspond to the state.

- static void setState(v8::Handle<v8::Object> internal, PromiseState, v8::Handle<v8::Value>, v8::Isolate*);

// Return true if |maybePromise| is a Promise instance.

static bool isPromise(v8::Handle<v8::Value> maybePromise, v8::Isolate*);