Support Promises instrumentation on backend.

Source/bindings/v8/custom/V8PromiseCustom.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 372 matching lines @@
         OwnPtr<Derived> derived = m_derivedStack.takeLast();
         updateDerived(derived->promise(isolate), derived->onFulfilled(isolate), derived->onRejected(isolate), derived->originator(isolate), isolate);
     }
 }
 
 void PromisePropagator::setValue(v8::Handle<v8::Object> promise, v8::Handle<v8::Value> value, v8::Isolate* isolate)
 {
     v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(promise);
     ASSERT(V8PromiseCustom::getState(internal) != V8PromiseCustom::Fulfilled && V8PromiseCustom::getState(internal) != V8PromiseCustom::Rejected);
     V8PromiseCustom::setState(internal, V8PromiseCustom::Fulfilled, value, isolate);
+    InspectorInstrumentation::updatePromiseState(currentExecutionContext(isolate), promise, V8PromiseCustom::Fulfilled);

[aandrey, 2014/02/25 12:36:07]

move inside V8PromiseCustom::setState

[Alexandra Mikhaylova, 2014/02/26 14:08:41]

It seems that we can't move the instrumentation inside V8PromiseCustom as
there's no our promise (but only internal of this promise) there.

I've instrumented all the places where V8PromiseCustom::setState is called,
instead.

[aandrey, 2014/02/26 16:17:42]

make V8PromiseCustom::setState accept a promise

[Alexandra Mikhaylova, 2014/02/28 13:52:05]

Done.

     propagateToDerived(promise, isolate);
 }
 
 void PromisePropagator::setReason(v8::Handle<v8::Object> promise, v8::Handle<v8::Value> reason, v8::Isolate* isolate)
 {
     v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(promise);
     ASSERT(V8PromiseCustom::getState(internal) != V8PromiseCustom::Fulfilled && V8PromiseCustom::getState(internal) != V8PromiseCustom::Rejected);
     V8PromiseCustom::setState(internal, V8PromiseCustom::Rejected, reason, isolate);
+    InspectorInstrumentation::updatePromiseState(currentExecutionContext(isolate), promise, V8PromiseCustom::Rejected);

[aandrey, 2014/02/25 12:36:07]

ditto

[Alexandra Mikhaylova, 2014/02/26 14:08:41]

see above

     propagateToDerived(promise, isolate);
 }
 
 void PromisePropagator::propagateToDerived(v8::Handle<v8::Object> promise, v8::Isolate* isolate)
 {
     v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(promise);
     ASSERT(V8PromiseCustom::getState(internal) == V8PromiseCustom::Fulfilled || V8PromiseCustom::getState(internal) == V8PromiseCustom::Rejected);
     v8::Local<v8::Array> fulfillCallbacks = internal->GetInternalField(V8PromiseCustom::InternalFulfillCallbackIndex).As<v8::Array>();
     v8::Local<v8::Array> rejectCallbacks = internal->GetInternalField(V8PromiseCustom::InternalRejectCallbackIndex).As<v8::Array>();
     v8::Local<v8::Array> derivedPromises = internal->GetInternalField(V8PromiseCustom::InternalDerivedPromiseIndex).As<v8::Array>();
@@ skipping 220 matching lines @@
 v8::Local<v8::Object> V8PromiseCustom::createPromise(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     v8::Local<v8::ObjectTemplate> internalTemplate = internalObjectTemplate(isolate);
     v8::Local<v8::Object> internal = internalTemplate->NewInstance();
     v8::Local<v8::Object> promise = V8DOMWrapper::createWrapper(creationContext, &V8Promise::wrapperTypeInfo, 0, isolate);
 
     clearDerived(internal, isolate);
     setState(internal, Pending, v8::Undefined(isolate), isolate);
 
     promise->SetInternalField(v8DOMWrapperObjectIndex, internal);
+
+    InspectorInstrumentation::addPromise(currentExecutionContext(isolate),

[aandrey, 2014/02/25 12:36:07]

one line

[Alexandra Mikhaylova, 2014/02/26 14:08:41]

Done.

+                                         promise,
+                                         v8::Handle<v8::Object>::Cast(v8::Null(isolate)),

[aandrey, 2014/02/25 12:36:07]

v8::Handle<v8::Object>()

[Alexandra Mikhaylova, 2014/02/26 14:08:41]

Done.

+                                         Pending);

[aandrey, 2014/02/25 12:36:07]

remove Pending, move up before setState()

[Alexandra Mikhaylova, 2014/02/26 14:08:41]

Done.

+
     return promise;
 }
 
 v8::Local<v8::Object> V8PromiseCustom::getInternal(v8::Handle<v8::Object> promise)
 {
     v8::Local<v8::Value> value = promise->GetInternalField(v8DOMWrapperObjectIndex);
     return value.As<v8::Object>();
 }
 
 V8PromiseCustom::PromiseState V8PromiseCustom::getState(v8::Handle<v8::Object> internal)
@@ skipping 49 matching lines @@
         } else if (valueState == Following) {
             v8::Local<v8::Object> valuePromiseFollowing = valueInternal->GetInternalField(InternalResultIndex).As<v8::Object>();
             setState(internal, Following, valuePromiseFollowing, isolate);
             addToDerived(getInternal(valuePromiseFollowing), promise, v8::Handle<v8::Function>(), v8::Handle<v8::Function>(), isolate);
         } else if (valueState == Fulfilled) {
             setValue(promise, valueInternal->GetInternalField(InternalResultIndex), isolate);
         } else if (valueState == Rejected) {
             setReason(promise, valueInternal->GetInternalField(InternalResultIndex), isolate);
         } else {
             ASSERT(valueState == Pending);
-            setState(internal, Following, valuePromise, isolate);
+            setState(internal, Following, valuePromise, isolate); // TODO: how can we track the Following state?

[aandrey, 2014/02/25 12:36:07]

remove todo

[Alexandra Mikhaylova, 2014/02/26 14:08:41]

Done.

             addToDerived(valueInternal, promise, v8::Handle<v8::Function>(), v8::Handle<v8::Function>(), isolate);
         }
     } else {
         setValue(promise, result, isolate);
     }
 }
 
 void V8PromiseCustom::reject(v8::Handle<v8::Object> promise, v8::Handle<v8::Value> reason, v8::Isolate* isolate)
 {
     v8::Local<v8::Object> internal = getInternal(promise);
     PromiseState state = getState(internal);
     if (state != Pending)
         return;
     setReason(promise, reason, isolate);
 }
 
 v8::Local<v8::Object> V8PromiseCustom::then(v8::Handle<v8::Object> promise, v8::Handle<v8::Function> onFulfilled, v8::Handle<v8::Function> onRejected, v8::Isolate* isolate)
 {
     v8::Handle<v8::Object> internal = getInternal(promise);
     while (getState(internal) == Following) {
         promise = internal->GetInternalField(InternalResultIndex).As<v8::Object>();
         internal = getInternal(promise);
     }
     // FIXME: Currently we don't lookup "constructor" property since we limit
     // the creation of the promise objects only from the Blink Promise
     // constructor.
     v8::Local<v8::Object> derivedPromise = createPromise(v8::Handle<v8::Object>(), isolate);
+    InspectorInstrumentation::updatePromiseParent(currentExecutionContext(isolate), derivedPromise, promise);

[aandrey, 2014/02/25 12:36:07]

move inside updateDerivedFromPromise()

[Alexandra Mikhaylova, 2014/02/26 14:08:41]

Done.

     updateDerivedFromPromise(derivedPromise, onFulfilled, onRejected, promise, isolate);
     return derivedPromise;
 }
 
 void V8PromiseCustom::setValue(v8::Handle<v8::Object> promise, v8::Handle<v8::Value> value, v8::Isolate* isolate)
 {
     PromisePropagator propagator;
     propagator.setValue(promise, value, isolate);
     propagator.performPropagation(isolate);
 }
@@ skipping 59 matching lines @@
 
 void V8PromiseCustom::callHandler(v8::Handle<v8::Object> promise, v8::Handle<v8::Function> handler, v8::Handle<v8::Value> argument, PromiseState originatorState, v8::Isolate* isolate)
 {
     ASSERT(originatorState == Fulfilled || originatorState == Rejected);
     ExecutionContext* executionContext = currentExecutionContext(isolate);
     ASSERT(executionContext && executionContext->isContextThread());
     executionContext->postTask(adoptPtr(new CallHandlerTask(promise, handler, argument, originatorState, isolate, executionContext)));
 }
 
 } // namespace WebCore