Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: lib/Transforms/NaCl/ReplacePtrsWithInts.cpp

Issue 17777004: Concurrency support for PNaCl ABI (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master
Patch Set: Fix bad merge. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/Transforms/NaCl/PNaClABISimplify.cpp ('k') | lib/Transforms/NaCl/ResolvePNaClIntrinsics.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/Transforms/NaCl/ReplacePtrsWithInts.cpp
diff --git a/lib/Transforms/NaCl/ReplacePtrsWithInts.cpp b/lib/Transforms/NaCl/ReplacePtrsWithInts.cpp
index cee574296f537e7464f0c7f56084385f207fb5d5..8e04190c5a19d5e03a0b9ff76f07ad7553286a82 100644
--- a/lib/Transforms/NaCl/ReplacePtrsWithInts.cpp
+++ b/lib/Transforms/NaCl/ReplacePtrsWithInts.cpp
@@ -483,19 +483,19 @@ static void ConvertInstruction(DataLayout *DL, Type *IntPtrType,
Value *Alloca2 = new PtrToIntInst(Tmp, IntPtrType,
Tmp->getName() + ".asint", Inst);
FC->recordConvertedAndErase(Alloca, Alloca2);
- } else if (// These atomics only operate on integer pointers, not
- // other pointers, so we don't need to recreate the
- // instruction.
- isa<AtomicCmpXchgInst>(Inst) ||
- isa<AtomicRMWInst>(Inst) ||
- // Handle these instructions as a convenience to allow
+ } else if (// Handle these instructions as a convenience to allow
// the pass to be used in more situations, even though we
// don't expect them in PNaCl's stable ABI.
isa<GetElementPtrInst>(Inst) ||
isa<VAArgInst>(Inst) ||
isa<IndirectBrInst>(Inst) ||
isa<ExtractValueInst>(Inst) ||
- isa<InsertValueInst>(Inst)) {
+ isa<InsertValueInst>(Inst) ||
+ // These atomics only operate on integer pointers, not
+ // other pointers, so we don't need to recreate the
+ // instruction.
+ isa<AtomicCmpXchgInst>(Inst) ||
+ isa<AtomicRMWInst>(Inst)) {
FC->convertInPlace(Inst);
}
}
« no previous file with comments | « lib/Transforms/NaCl/PNaClABISimplify.cpp ('k') | lib/Transforms/NaCl/ResolvePNaClIntrinsics.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698