Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: test/NaCl/PNaClABI/abi-alignment.ll

Issue 17777004: Concurrency support for PNaCl ABI (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master
Patch Set: Missed one cleanup file. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/NaCl/PNaClABI/abi-alignment.ll
diff --git a/test/NaCl/PNaClABI/abi-alignment.ll b/test/NaCl/PNaClABI/abi-alignment.ll
index a31914e4be9c4fe8ee9741b1de4b685348a2e602..743807f07d40186f056845374ec11347ab7756fb 100644
--- a/test/NaCl/PNaClABI/abi-alignment.ll
+++ b/test/NaCl/PNaClABI/abi-alignment.ll
@@ -1,8 +1,7 @@
; RUN: pnacl-abicheck < %s | FileCheck %s
; Test the "align" attributes that are allowed on load and store
-; instructions. Note that "cmpxchg" and "atomicrmw" do not take
-; "align" attributes, so are not tested here.
+; instructions.
declare void @llvm.memcpy.p0i8.p0i8.i32(i8*, i8*, i32, i32, i1)
@@ -27,14 +26,6 @@ define internal void @allowed_cases(i32 %ptr, float %f, double %d) {
store double %d, double* %ptr.double, align 1
store double %d, double* %ptr.double, align 8
- ; Stricter alignments are required for atomics.
- load atomic i32* %ptr.i32 seq_cst, align 4
- store atomic i32 123, i32* %ptr.i32 seq_cst, align 4
- load atomic float* %ptr.float seq_cst, align 4
- store atomic float %f, float* %ptr.float seq_cst, align 4
- load atomic double* %ptr.double seq_cst, align 8
- store atomic double %d, double* %ptr.double seq_cst, align 8
-
; memcpy() et el take an alignment parameter, which is allowed to be 1.
%ptr.p = inttoptr i32 %ptr to i8*
call void @llvm.memcpy.p0i8.p0i8.i32(i8* %ptr.p, i8* %ptr.p,
@@ -77,22 +68,6 @@ define internal void @rejected_cases(i32 %ptr, float %f, double %d, i32 %align)
; CHECK-NEXT: disallowed: bad alignment: store double{{.*}} align 2
; CHECK-NEXT: disallowed: bad alignment: store double{{.*}} align 4
- ; Too-small alignments for atomics are rejected.
- load atomic i32* %ptr.i32 seq_cst, align 2
- load atomic float* %ptr.float seq_cst, align 2
- load atomic double* %ptr.double seq_cst, align 4
-; CHECK-NEXT: disallowed: bad alignment: {{.*}} load atomic i32{{.*}} align 2
-; CHECK-NEXT: disallowed: bad alignment: {{.*}} load atomic float{{.*}} align 2
-; CHECK-NEXT: disallowed: bad alignment: {{.*}} load atomic double{{.*}} align 4
-
- ; Too-large alignments for atomics are also rejected.
- load atomic i32* %ptr.i32 seq_cst, align 8
- load atomic float* %ptr.float seq_cst, align 8
- load atomic double* %ptr.double seq_cst, align 16
-; CHECK-NEXT: disallowed: bad alignment: {{.*}} load atomic i32{{.*}} align 8
-; CHECK-NEXT: disallowed: bad alignment: {{.*}} load atomic float{{.*}} align 8
-; CHECK-NEXT: disallowed: bad alignment: {{.*}} load atomic double{{.*}} align 16
-
; Non-pessimistic alignments for memcpy() et al are rejected.
%ptr.p = inttoptr i32 %ptr to i8*
call void @llvm.memcpy.p0i8.p0i8.i32(i8* %ptr.p, i8* %ptr.p,

Powered by Google App Engine
This is Rietveld 408576698