[mojo-bindings] Use Watcher API for JS bindings

[mojo-bindings] Use Watcher API for JS bindings

BUG=592183
Committed: https://crrev.com/b98777bcf33f467bba92cff7de951f0b3fd13b32
Cr-Commit-Position: refs/heads/master@{#380092}

[Ken Rockot(use gerrit already), 2016-03-08 22:09:22]

rockot@chromium.org changed reviewers:
+ yzshen@chromium.org

[Ken Rockot(use gerrit already), 2016-03-08 22:09:23]

Yuzhu, please take a look. Straightforward change to stop using HandleWatcher
from core JS bindings.

asyncWait/cancelWait still have a few uses that I've left in place for now

[yzshen1, 2016-03-08 22:37:25]

lgtm

https://codereview.chromium.org/1777673003/diff/1/mojo/edk/js/waiting_callback.h
File mojo/edk/js/waiting_callback.h (right):

https://codereview.chromium.org/1777673003/diff/1/mojo/edk/js/waiting_callbac...
mojo/edk/js/waiting_callback.h:62: // Indicates whether this is a one-shot
callback or not. If so, it uses the
It seems straightforward to use the new Watcher API to also support one-shot
watch. Is there reason not the directly remove the common::HandleWatcher code?

(But I am okay with this if you believe the current way is easier to move
forward.)

[Ken Rockot(use gerrit already), 2016-03-08 22:54:50]

Thanks. I went ahead and removed HandleWatcher usage altogether. Less code!

[yzshen1, 2016-03-08 23:02:42]

LGTM++
Thanks!

https://codereview.chromium.org/1777673003/diff/20001/mojo/edk/js/waiting_cal...
File mojo/edk/js/waiting_callback.cc (right):

https://codereview.chromium.org/1777673003/diff/20001/mojo/edk/js/waiting_cal...
mojo/edk/js/waiting_callback.cc:65: void
WaitingCallback::OnHandleReady(MojoResult result) {
Nit: this method could be removed, because it only forwards to CallCallback().

https://codereview.chromium.org/1777673003/diff/20001/mojo/edk/js/waiting_cal...
File mojo/edk/js/waiting_callback.h (right):

https://codereview.chromium.org/1777673003/diff/20001/mojo/edk/js/waiting_cal...
mojo/edk/js/waiting_callback.h:14: #include
"mojo/edk/js/handle_close_observer.h"
nit: This is not needed anymore.

[Ken Rockot(use gerrit already), 2016-03-09 05:25:24]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-03-09 05:25:24]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1777673003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-09 05:25:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777673003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777673003/40001

[Ken Rockot(use gerrit already), 2016-03-09 05:25:37]

On 2016/03/08 at 23:02:42, yzshen wrote:
> LGTM++
> Thanks!
> 
>
https://codereview.chromium.org/1777673003/diff/20001/mojo/edk/js/waiting_cal...
> File mojo/edk/js/waiting_callback.cc (right):
> 
>
https://codereview.chromium.org/1777673003/diff/20001/mojo/edk/js/waiting_cal...
> mojo/edk/js/waiting_callback.cc:65: void
WaitingCallback::OnHandleReady(MojoResult result) {
> Nit: this method could be removed, because it only forwards to CallCallback().
> 

done

>
https://codereview.chromium.org/1777673003/diff/20001/mojo/edk/js/waiting_cal...
> File mojo/edk/js/waiting_callback.h (right):
> 
>
https://codereview.chromium.org/1777673003/diff/20001/mojo/edk/js/waiting_cal...
> mojo/edk/js/waiting_callback.h:14: #include
"mojo/edk/js/handle_close_observer.h"
> nit: This is not needed anymore.

done

[commit-bot: I haz the power, 2016-03-09 06:35:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-09 06:36:25]

Description was changed from

==========
[mojo-bindings] Use Watcher API for JS bindings

BUG=592183
==========

to

==========
[mojo-bindings] Use Watcher API for JS bindings

BUG=592183

Committed: https://crrev.com/b98777bcf33f467bba92cff7de951f0b3fd13b32
Cr-Commit-Position: refs/heads/master@{#380092}
==========

[commit-bot: I haz the power, 2016-03-09 06:36:26]

Patchset 3 (id:??) landed as
https://crrev.com/b98777bcf33f467bba92cff7de951f0b3fd13b32
Cr-Commit-Position: refs/heads/master@{#380092}