Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1749)

Unified Diff: ui/views/controls/menu/menu_runner_impl_cocoa.mm

Issue 1777653002: Prepare ui/ module for compilation with OS X 10.7 deployment target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/menu/menu_runner_impl_cocoa.mm
diff --git a/ui/views/controls/menu/menu_runner_impl_cocoa.mm b/ui/views/controls/menu/menu_runner_impl_cocoa.mm
index 47547814cf831b6d72bcb29a2e2ea02ad41e63fa..b623a18428f4ca969efeab49e79b5ade9eb6dfd7 100644
--- a/ui/views/controls/menu/menu_runner_impl_cocoa.mm
+++ b/ui/views/controls/menu/menu_runner_impl_cocoa.mm
@@ -41,7 +41,7 @@ base::scoped_nsobject<NSView> CreateMenuAnchorView(
const gfx::Rect& screen_bounds,
NSMenuItem* checked_item) {
NSRect rect = gfx::ScreenRectToNSRect(screen_bounds);
- rect.origin = [window convertScreenToBase:rect.origin];
+ rect.origin = [window convertRectFromScreen:rect].origin;
Avi (use Gerrit) 2016/03/08 20:07:54 Do rect = [window convertRectFromScreen:rect]; A
erikchen 2016/03/08 20:57:41 Done.
rect = [[window contentView] convertRect:rect fromView:nil];
// If there's no checked item (e.g. Combobox::STYLE_ACTION), NSMenu will

Powered by Google App Engine
This is Rietveld 408576698