Prepare ui/ module for compilation with OS X 10.7 deployment target.

Prepare ui/ module for compilation with OS X 10.7 deployment target.

1. Added utility methods ConvertPointFromWindowToScreen and
ConvertPointFromScreenToWindow to replace deprecated methods
convertBaseToScreen: and convertBaseFromScreen:.
2. Always use -backingScaleFactor. Never use -userSpaceScaleFactor.

The utility methods added in (1) will also be used extensively in the content/
and chrome/ modules.

BUG=592663
Committed: https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095
Cr-Commit-Position: refs/heads/master@{#379971}

[erikchen, 2016-03-08 19:11:52]

Description was changed from

==========
Prepare ui/ module for compilation with OS X 10.7 deployment target.

BUG=592663
==========

to

==========
Prepare ui/ module for compilation with OS X 10.7 deployment target.

1. Added utility methods ConvertPointFromWindowToScreen and
ConvertPointFromScreenToWindow to replace deprecated methods
convertBaseToScreen: and convertBaseFromScreen:.
2. Remove unused method -pressureChangeWithEvent:.
3. Always use -backingScaleFactor. Never use -userSpaceScaleFactor.

The utility methods added in (1) will also be used extensively in the content/
and chrome/ modules.

BUG=592663
==========

[erikchen, 2016-03-08 19:25:54]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-03-08 19:26:05]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-03-08 19:26:06]

avi: Please review.

[commit-bot: I haz the power, 2016-03-08 19:26:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777653002/1

[commit-bot: I haz the power, 2016-03-08 19:39:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 19:39:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Avi (use Gerrit), 2016-03-08 20:07:54]

https://codereview.chromium.org/1777653002/diff/1/ui/base/cocoa/base_view.mm
File ui/base/cocoa/base_view.mm (left):

https://codereview.chromium.org/1777653002/diff/1/ui/base/cocoa/base_view.mm#...
ui/base/cocoa/base_view.mm:181: [self forceTouchEvent:theEvent];
I'm rather uncomfortable here. While it seems like no one is calling
-pressureChangeWithEvent:, this call to -forceTouchEvent: seems to be overridden
in RenderWidgetHostViewMac (see
https://code.google.com/p/chromium/codesearch#search/&q=forceTouchEvent ).
Either this should somehow be hooked in, or the other code should be removed.

https://codereview.chromium.org/1777653002/diff/1/ui/base/cocoa/base_view.mm#...
ui/base/cocoa/base_view.mm:183: pressureEventStage_ = newStage;
pressureEventStage_ is only used in this method; if we remove this method remove
the variable from the class definition in the .h file.

https://codereview.chromium.org/1777653002/diff/1/ui/snapshot/snapshot_mac.mm
File ui/snapshot/snapshot_mac.mm (right):

https://codereview.chromium.org/1777653002/diff/1/ui/snapshot/snapshot_mac.mm...
ui/snapshot/snapshot_mac.mm:29: frame.origin = [window
convertRectToScreen:frame].origin;
Just do

frame = [window convertRectToScreen:frame];

and let the system method do its job.

https://codereview.chromium.org/1777653002/diff/1/ui/views/cocoa/widget_owner...
File ui/views/cocoa/widget_owner_nswindow_adapter.mm (right):

https://codereview.chromium.org/1777653002/diff/1/ui/views/cocoa/widget_owner...
ui/views/cocoa/widget_owner_nswindow_adapter.mm:81:
NSMakePoint(NSMinX(rect_in_window), NSMaxY(rect_in_window)));
Can we rewrite this so we do:

NSRect rect_in_window = ...
NSRect rect_in_screen = [anchor_window_ convertRectToScreen:rect_in_window];

and _then_ fiddle with the origin? If it's not too much work, that would be
cleaner.

https://codereview.chromium.org/1777653002/diff/1/ui/views/controls/menu/menu...
File ui/views/controls/menu/menu_runner_impl_cocoa.mm (right):

https://codereview.chromium.org/1777653002/diff/1/ui/views/controls/menu/menu...
ui/views/controls/menu/menu_runner_impl_cocoa.mm:44: rect.origin = [window
convertRectFromScreen:rect].origin;
Do

rect = [window convertRectFromScreen:rect];

Again, we were compensating for the lack of rect conversion by only converting
the origin. Now that we have full rect conversion, can we let the conversion do
its thing?

[Avi (use Gerrit), 2016-03-08 20:13:08]

https://codereview.chromium.org/1777653002/diff/1/ui/base/cocoa/base_view.mm
File ui/base/cocoa/base_view.mm (left):

https://codereview.chromium.org/1777653002/diff/1/ui/base/cocoa/base_view.mm#...
ui/base/cocoa/base_view.mm:181: [self forceTouchEvent:theEvent];
On 2016/03/08 20:07:54, Avi wrote:
> I'm rather uncomfortable here. While it seems like no one is calling
> -pressureChangeWithEvent:, this call to -forceTouchEvent: seems to be
overridden
> in RenderWidgetHostViewMac (see
> https://code.google.com/p/chromium/codesearch#search/&q=forceTouchEvent ).
> Either this should somehow be hooked in, or the other code should be removed.

OK, I'm really unsure about this. -pressureChangeWithEvent: seems to be the hook
for Force Touch (see
http://www.metaltoad.com/blog/use-the-force-touch-mac-programming ,
https://gregheo.com/blog/force-touch/ , and
https://webkit.googlesource.com/WebKit/+/dc0d9c76834640b3f2c9a180cf2e1ff5e8aa...
).

[erikchen, 2016-03-08 20:57:41]

https://codereview.chromium.org/1777653002/diff/1/ui/base/cocoa/base_view.mm
File ui/base/cocoa/base_view.mm (left):

https://codereview.chromium.org/1777653002/diff/1/ui/base/cocoa/base_view.mm#...
ui/base/cocoa/base_view.mm:181: [self forceTouchEvent:theEvent];
On 2016/03/08 20:13:08, Avi wrote:
> On 2016/03/08 20:07:54, Avi wrote:
> > I'm rather uncomfortable here. While it seems like no one is calling
> > -pressureChangeWithEvent:, this call to -forceTouchEvent: seems to be
> overridden
> > in RenderWidgetHostViewMac (see
> > https://code.google.com/p/chromium/codesearch#search/&q=forceTouchEvent ).
> > Either this should somehow be hooked in, or the other code should be
removed.
> 
> OK, I'm really unsure about this. -pressureChangeWithEvent: seems to be the
hook
> for Force Touch (see
> http://www.metaltoad.com/blog/use-the-force-touch-mac-programming ,
> https://gregheo.com/blog/force-touch/ , and
>
https://webkit.googlesource.com/WebKit/+/dc0d9c76834640b3f2c9a180cf2e1ff5e8aa...
> ).

Whoops! Good catch.

https://codereview.chromium.org/1777653002/diff/1/ui/snapshot/snapshot_mac.mm
File ui/snapshot/snapshot_mac.mm (right):

https://codereview.chromium.org/1777653002/diff/1/ui/snapshot/snapshot_mac.mm...
ui/snapshot/snapshot_mac.mm:29: frame.origin = [window
convertRectToScreen:frame].origin;
On 2016/03/08 20:07:54, Avi wrote:
> Just do
> 
> frame = [window convertRectToScreen:frame];
> 
> and let the system method do its job.

Done.

https://codereview.chromium.org/1777653002/diff/1/ui/views/cocoa/widget_owner...
File ui/views/cocoa/widget_owner_nswindow_adapter.mm (right):

https://codereview.chromium.org/1777653002/diff/1/ui/views/cocoa/widget_owner...
ui/views/cocoa/widget_owner_nswindow_adapter.mm:81:
NSMakePoint(NSMinX(rect_in_window), NSMaxY(rect_in_window)));
On 2016/03/08 20:07:54, Avi wrote:
> Can we rewrite this so we do:
> 
> NSRect rect_in_window = ...
> NSRect rect_in_screen = [anchor_window_ convertRectToScreen:rect_in_window];
> 
> and _then_ fiddle with the origin? If it's not too much work, that would be
> cleaner.

Done.

https://codereview.chromium.org/1777653002/diff/1/ui/views/controls/menu/menu...
File ui/views/controls/menu/menu_runner_impl_cocoa.mm (right):

https://codereview.chromium.org/1777653002/diff/1/ui/views/controls/menu/menu...
ui/views/controls/menu/menu_runner_impl_cocoa.mm:44: rect.origin = [window
convertRectFromScreen:rect].origin;
On 2016/03/08 20:07:54, Avi wrote:
> Do
> 
> rect = [window convertRectFromScreen:rect];
> 
> Again, we were compensating for the lack of rect conversion by only converting
> the origin. Now that we have full rect conversion, can we let the conversion
do
> its thing?

Done.

[erikchen, 2016-03-08 21:03:23]

Description was changed from

==========
Prepare ui/ module for compilation with OS X 10.7 deployment target.

1. Added utility methods ConvertPointFromWindowToScreen and
ConvertPointFromScreenToWindow to replace deprecated methods
convertBaseToScreen: and convertBaseFromScreen:.
2. Remove unused method -pressureChangeWithEvent:.
3. Always use -backingScaleFactor. Never use -userSpaceScaleFactor.

The utility methods added in (1) will also be used extensively in the content/
and chrome/ modules.

BUG=592663
==========

to

==========
Prepare ui/ module for compilation with OS X 10.7 deployment target.

1. Added utility methods ConvertPointFromWindowToScreen and
ConvertPointFromScreenToWindow to replace deprecated methods
convertBaseToScreen: and convertBaseFromScreen:.
2. Always use -backingScaleFactor. Never use -userSpaceScaleFactor.

The utility methods added in (1) will also be used extensively in the content/
and chrome/ modules.

BUG=592663
==========

[Avi (use Gerrit), 2016-03-08 21:37:40]

lgtm

https://codereview.chromium.org/1777653002/diff/40001/ui/views/cocoa/widget_o...
File ui/views/cocoa/widget_owner_nswindow_adapter.mm (right):

https://codereview.chromium.org/1777653002/diff/40001/ui/views/cocoa/widget_o...
ui/views/cocoa/widget_owner_nswindow_adapter.mm:77: // Ensure we anchor off the
top-left of |anchor_view_| (rect_in_window.origin
... (rect_in_screen.origin

[erikchen, 2016-03-08 21:42:10]

https://codereview.chromium.org/1777653002/diff/40001/ui/views/cocoa/widget_o...
File ui/views/cocoa/widget_owner_nswindow_adapter.mm (right):

https://codereview.chromium.org/1777653002/diff/40001/ui/views/cocoa/widget_o...
ui/views/cocoa/widget_owner_nswindow_adapter.mm:77: // Ensure we anchor off the
top-left of |anchor_view_| (rect_in_window.origin
On 2016/03/08 21:37:40, Avi wrote:
> ... (rect_in_screen.origin

Done.

[erikchen, 2016-03-08 21:42:15]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-08 21:42:15]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1777653002/#ps60001
(title: "Comments from avi.")

[commit-bot: I haz the power, 2016-03-08 21:42:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777653002/60001

[commit-bot: I haz the power, 2016-03-08 21:49:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 21:49:32]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[erikchen, 2016-03-08 22:32:15]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-08 22:32:15]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1777653002/#ps80001
(title: "Fix deps and compile errors.")

[commit-bot: I haz the power, 2016-03-08 22:33:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777653002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777653002/80001

[commit-bot: I haz the power, 2016-03-08 22:46:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 22:46:53]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[erikchen, 2016-03-08 22:58:04]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-08 22:58:04]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1777653002/#ps100001
(title: "More compile errors.")

[commit-bot: I haz the power, 2016-03-08 22:58:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777653002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777653002/100001

[commit-bot: I haz the power, 2016-03-08 23:49:25]

Description was changed from

==========
Prepare ui/ module for compilation with OS X 10.7 deployment target.

1. Added utility methods ConvertPointFromWindowToScreen and
ConvertPointFromScreenToWindow to replace deprecated methods
convertBaseToScreen: and convertBaseFromScreen:.
2. Always use -backingScaleFactor. Never use -userSpaceScaleFactor.

The utility methods added in (1) will also be used extensively in the content/
and chrome/ modules.

BUG=592663
==========

to

==========
Prepare ui/ module for compilation with OS X 10.7 deployment target.

1. Added utility methods ConvertPointFromWindowToScreen and
ConvertPointFromScreenToWindow to replace deprecated methods
convertBaseToScreen: and convertBaseFromScreen:.
2. Always use -backingScaleFactor. Never use -userSpaceScaleFactor.

The utility methods added in (1) will also be used extensively in the content/
and chrome/ modules.

BUG=592663
==========

[commit-bot: I haz the power, 2016-03-08 23:49:26]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-08 23:50:59]

Description was changed from

==========
Prepare ui/ module for compilation with OS X 10.7 deployment target.

1. Added utility methods ConvertPointFromWindowToScreen and
ConvertPointFromScreenToWindow to replace deprecated methods
convertBaseToScreen: and convertBaseFromScreen:.
2. Always use -backingScaleFactor. Never use -userSpaceScaleFactor.

The utility methods added in (1) will also be used extensively in the content/
and chrome/ modules.

BUG=592663
==========

to

==========
Prepare ui/ module for compilation with OS X 10.7 deployment target.

1. Added utility methods ConvertPointFromWindowToScreen and
ConvertPointFromScreenToWindow to replace deprecated methods
convertBaseToScreen: and convertBaseFromScreen:.
2. Always use -backingScaleFactor. Never use -userSpaceScaleFactor.

The utility methods added in (1) will also be used extensively in the content/
and chrome/ modules.

BUG=592663

Committed: https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095
Cr-Commit-Position: refs/heads/master@{#379971}
==========

[commit-bot: I haz the power, 2016-03-08 23:51:03]

Patchset 6 (id:??) landed as
https://crrev.com/71b49b37f73d3ae1fe219937620aa1f1e6197095
Cr-Commit-Position: refs/heads/master@{#379971}