sdk/lib/io/websocket_impl.dart - Issue 1777643003: Uses a finalizer to delete zlib filter resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/websocket_impl.dart

Issue 1777643003: Uses a finalizer to delete zlib filter resources (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments. Fix more problems. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/io/websocket_impl.dart

diff --git a/sdk/lib/io/websocket_impl.dart b/sdk/lib/io/websocket_impl.dart

index 2aa894c20a49fe81e10021d198e9f3def6a1a4d2..6acd661bebc42fc99e914c2e40aa4d0477c1e962 100644

--- a/sdk/lib/io/websocket_impl.dart

+++ b/sdk/lib/io/websocket_impl.dart

@@ -581,7 +581,6 @@ class _WebSocketPerMessageDeflate {

if ((serverSide && clientNoContextTakeover) ||

(!serverSide && serverNoContextTakeover)) {

- decoder.end();

decoder = null;

}

@@ -614,7 +613,6 @@ class _WebSocketPerMessageDeflate {

if ((!serverSide && clientNoContextTakeover) ||

(serverSide && serverNoContextTakeover)) {

- encoder.end();

encoder = null;

}

« runtime/bin/filter.cc ('K') | « sdk/lib/io/data_transformer.dart ('k') | no next file » | no next file with comments »