Fix serialization of (xlink:)href attributes in document fragments

Fix serialization of (xlink:)href attributes in document fragments

If the namespace of an attribute has a "well-known" prefix, then make
sure that prefix is used during serialization instead of the prefix
from the attribute (which could be empty.)

BUG=345132
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167779

[adamk, 2014-02-24 19:05:31]

lgtm but you might consider re-using existing testing infrastructure for your
test.

https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSeri...
File LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html (right):

https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSeri...
LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html:3: function
debug(str) {
You'd get this for free if you used

<script src="../../resources/js-test.js"></script>

https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSeri...
LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html:11:
testRunner.dumpAsText();
Same with this

https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSeri...
LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html:29: <p>This tests
that XMLSerializer emits a correct namespace declaration for the &lt;image>
element. The first line is serialized as part of a DocumentFragment. The second
line is serialized as part of the Document.</p>
And then you'd pass this to the description() function and remove all the DOM
after </script>, above.

[fs, 2014-02-25 08:26:40]

On 2014/02/24 19:05:31, adamk wrote:
> lgtm but you might consider re-using existing testing infrastructure for your
> test.

I'll do that, thanks. (Apparently I looked at the wrong test for guidance...).

[fs, 2014-02-25 08:51:34]

https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSeri...
File LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html (right):

https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSeri...
LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html:3: function
debug(str) {
On 2014/02/24 19:05:32, adamk wrote:
> You'd get this for free if you used
> 
> <script src="../../resources/js-test.js"></script>

Done.

https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSeri...
LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html:11:
testRunner.dumpAsText();
On 2014/02/24 19:05:32, adamk wrote:
> Same with this

Done.

https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSeri...
LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html:29: <p>This tests
that XMLSerializer emits a correct namespace declaration for the &lt;image>
element. The first line is serialized as part of a DocumentFragment. The second
line is serialized as part of the Document.</p>
On 2014/02/24 19:05:32, adamk wrote:
> And then you'd pass this to the description() function and remove all the DOM
> after </script>, above.

Done.

[fs, 2014-02-25 08:51:40]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-02-25 08:51:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/177763002/70001

[commit-bot: I haz the power, 2014-02-25 13:27:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/177763002/70001

[commit-bot: I haz the power, 2014-02-25 15:06:29]

Change committed as 167779