Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 177763002: Fix serialization of (xlink:)href attributes in document fragments (Closed)

Created:
6 years, 10 months ago by fs
Modified:
6 years, 10 months ago
Reviewers:
adamk
CC:
blink-reviews
Visibility:
Public.

Description

Fix serialization of (xlink:)href attributes in document fragments If the namespace of an attribute has a "well-known" prefix, then make sure that prefix is used during serialization instead of the prefix from the attribute (which could be empty.) BUG=345132 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167779

Patch Set 1 #

Total comments: 6

Patch Set 2 : Use js-test framework. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
A LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
fs
6 years, 10 months ago (2014-02-24 15:41:34 UTC) #1
adamk
lgtm but you might consider re-using existing testing infrastructure for your test. https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html File LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html ...
6 years, 10 months ago (2014-02-24 19:05:31 UTC) #2
fs
On 2014/02/24 19:05:31, adamk wrote: > lgtm but you might consider re-using existing testing infrastructure ...
6 years, 10 months ago (2014-02-25 08:26:40 UTC) #3
fs
https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html File LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html (right): https://codereview.chromium.org/177763002/diff/1/LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html#newcode3 LayoutTests/fast/dom/XMLSerializer-attribute-ns-prefix.html:3: function debug(str) { On 2014/02/24 19:05:32, adamk wrote: > ...
6 years, 10 months ago (2014-02-25 08:51:34 UTC) #4
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-25 08:51:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/177763002/70001
6 years, 10 months ago (2014-02-25 08:51:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/177763002/70001
6 years, 10 months ago (2014-02-25 13:27:22 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 15:06:29 UTC) #8
Message was sent while issue was closed.
Change committed as 167779

Powered by Google App Engine
This is Rietveld 408576698