Gerrit git cl upload: record issue id for a branch.

Gerrit git cl upload: record issue id for a branch.

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299312

[tandrii(chromium), 2016-03-12 00:43:44]

Description was changed from

==========
Gerrit git cl uploda: record issue id for a branch.

BUG=
==========

to

==========
Gerrit git cl upload: record issue id for a branch.

BUG=
==========

[tandrii(chromium), 2016-03-15 14:32:37]

tandrii@chromium.org changed reviewers:
+ andybons@chromium.org, phajdan.jr@chromium.org

[tandrii(chromium), 2016-03-15 14:32:41]

PTAL

this finally works. Parsing Gerrit output is ugly, but it should be working.

[tandrii(chromium), 2016-03-15 14:38:55]

tandrii@chromium.org changed reviewers:
+ machenbach@chromium.org

[tandrii(chromium), 2016-03-15 14:38:56]

+machenbach@ for EMEA review.

https://codereview.chromium.org/1777603002/diff/320001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1777603002/diff/320001/git_cl.py#newcode2315
git_cl.py:2315: if options.squash:
only in squash case, as we'll only support this case going forward. if someone
wants to use non-squash form, it's a simple as manual git push.

https://codereview.chromium.org/1777603002/diff/320001/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/1777603002/diff/320001/tests/git_cl_test.py#n...
tests/git_cl_test.py:659: 'remote:  
https://chromium-review.googlesource.com/123456 XXX.\n'
this is the line I'm regex-ing for.

[tandrii(chromium), 2016-03-15 14:40:22]

Ah, and forgot to mention, this works on 3 platforms. Proof: 
https://codereview.chromium.org/1662993002/#ps930001

[Paweł Hajdan Jr., 2016-03-15 15:06:06]

LGTM

[tandrii(chromium), 2016-03-15 15:08:22]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-03-15 15:08:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777603002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777603002/320001

[commit-bot: I haz the power, 2016-03-15 15:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 15:13:24]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[Bons, 2016-03-15 15:24:11]

lgtm

[tandrii(chromium), 2016-03-15 22:16:44]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-15 22:16:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777603002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777603002/340001

[commit-bot: I haz the power, 2016-03-15 22:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 22:19:27]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-03-16 07:05:40]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-03-16 07:05:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org, phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1777603002/#ps340001
(title: "Fix presubmit + improve error message.")

[commit-bot: I haz the power, 2016-03-16 07:05:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777603002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777603002/340001

[commit-bot: I haz the power, 2016-03-16 07:08:26]

Description was changed from

==========
Gerrit git cl upload: record issue id for a branch.

BUG=
==========

to

==========
Gerrit git cl upload: record issue id for a branch.

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299312
==========

[commit-bot: I haz the power, 2016-03-16 07:08:27]

Committed patchset #18 (id:340001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299312

[Michael Achenbach, 2016-03-16 09:44:29]

lgtm

https://codereview.chromium.org/1777603002/diff/340001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1777603002/diff/340001/git_cl.py#newcode2174
git_cl.py:2174: return new_log_desc
Where is this used? It's a bit odd that the method doesn't return in all
control-flow cases. Or is this pythonish as the default will be None?

[tandrii(chromium), 2016-03-16 10:09:24]

https://codereview.chromium.org/1777603002/diff/340001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1777603002/diff/340001/git_cl.py#newcode2174
git_cl.py:2174: return new_log_desc
On 2016/03/16 09:44:28, Michael Achenbach wrote:
> Where is this used? It's a bit odd that the method doesn't return in all
> control-flow cases. Or is this pythonish as the default will be None?

it's not pythonic, but yes default is None. I'll fix this in the next CL, thanks
for comment. That said, that codepath still fails anyway immediately afterwards.