Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: crypto/signature_verifier_nss.cc

Issue 17776003: Add SignatureVerifier::VerifyInitRSAPSS for verifying RSA-PSS signatures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Work around the lack of HASH_GetType and HASH_ResultLenContext Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « crypto/signature_verifier.h ('k') | crypto/signature_verifier_openssl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "crypto/signature_verifier.h" 5 #include "crypto/signature_verifier.h"
6 6
7 #include <cryptohi.h> 7 #include <cryptohi.h>
8 #include <keyhi.h> 8 #include <keyhi.h>
9 #include <pk11pub.h>
10 #include <secerr.h>
11 #include <sechash.h>
9 #include <stdlib.h> 12 #include <stdlib.h>
10 13
11 #include "base/logging.h" 14 #include "base/logging.h"
12 #include "crypto/nss_util.h" 15 #include "crypto/nss_util.h"
16 #include "crypto/third_party/nss/chromium-nss.h"
13 17
14 namespace crypto { 18 namespace crypto {
15 19
16 SignatureVerifier::SignatureVerifier() : vfy_context_(NULL) { 20 namespace {
21
22 HASH_HashType ToNSSHashType(SignatureVerifier::HashAlgorithm hash_alg) {
23 switch (hash_alg) {
24 case SignatureVerifier::SHA1:
25 return HASH_AlgSHA1;
26 case SignatureVerifier::SHA256:
27 return HASH_AlgSHA256;
28 }
29 return HASH_AlgNULL;
30 }
31
32 SECStatus VerifyRSAPSS_End(SECKEYPublicKey* public_key,
33 HASHContext* hash_context,
34 HASH_HashType mask_hash_alg,
35 unsigned int salt_len,
36 const unsigned char* signature,
37 unsigned int signature_len) {
38 unsigned int hash_len = hash_context->hashobj->length;
39 std::vector<unsigned char> hash(hash_len);
40 HASH_End(hash_context, &hash[0], &hash_len, hash.size());
41
42 unsigned int modulus_len = SECKEY_PublicKeyStrength(public_key);
43 if (signature_len != modulus_len) {
44 PORT_SetError(SEC_ERROR_BAD_SIGNATURE);
45 return SECFailure;
46 }
47 std::vector<unsigned char> enc(signature_len);
48 SECStatus rv = PK11_PubEncryptRaw(public_key, &enc[0],
49 const_cast<unsigned char*>(signature),
50 signature_len, NULL);
51 if (rv != SECSuccess) {
52 LOG(WARNING) << "PK11_PubEncryptRaw failed";
53 return rv;
54 }
55 return emsa_pss_verify(&hash[0], &enc[0], enc.size(),
56 hash_context->hashobj->type, mask_hash_alg,
57 salt_len);
58 }
59
60 } // namespace
61
62 SignatureVerifier::SignatureVerifier()
63 : vfy_context_(NULL),
64 hash_alg_(SHA1),
65 mask_hash_alg_(SHA1),
66 salt_len_(0),
67 public_key_(NULL),
68 hash_context_(NULL) {
17 EnsureNSSInit(); 69 EnsureNSSInit();
18 } 70 }
19 71
20 SignatureVerifier::~SignatureVerifier() { 72 SignatureVerifier::~SignatureVerifier() {
21 Reset(); 73 Reset();
22 } 74 }
23 75
24 bool SignatureVerifier::VerifyInit(const uint8* signature_algorithm, 76 bool SignatureVerifier::VerifyInit(const uint8* signature_algorithm,
25 int signature_algorithm_len, 77 int signature_algorithm_len,
26 const uint8* signature, 78 const uint8* signature,
27 int signature_len, 79 int signature_len,
28 const uint8* public_key_info, 80 const uint8* public_key_info,
29 int public_key_info_len) { 81 int public_key_info_len) {
82 if (vfy_context_ || hash_context_)
83 return false;
84
30 signature_.assign(signature, signature + signature_len); 85 signature_.assign(signature, signature + signature_len);
31 86
32 CERTSubjectPublicKeyInfo* spki = NULL; 87 SECKEYPublicKey* public_key = DecodePublicKeyInfo(public_key_info,
33 SECItem spki_der; 88 public_key_info_len);
34 spki_der.type = siBuffer;
35 spki_der.data = const_cast<uint8*>(public_key_info);
36 spki_der.len = public_key_info_len;
37 spki = SECKEY_DecodeDERSubjectPublicKeyInfo(&spki_der);
38 if (!spki)
39 return false;
40 SECKEYPublicKey* public_key = SECKEY_ExtractPublicKey(spki);
41 SECKEY_DestroySubjectPublicKeyInfo(spki); // Done with spki.
42 if (!public_key) 89 if (!public_key)
43 return false; 90 return false;
44 91
45 PLArenaPool* arena = PORT_NewArena(DER_DEFAULT_CHUNKSIZE); 92 PLArenaPool* arena = PORT_NewArena(DER_DEFAULT_CHUNKSIZE);
46 if (!arena) { 93 if (!arena) {
47 SECKEY_DestroyPublicKey(public_key); 94 SECKEY_DestroyPublicKey(public_key);
48 return false; 95 return false;
49 } 96 }
50 97
51 SECItem sig_alg_der; 98 SECItem sig_alg_der;
(...skipping 29 matching lines...) Expand all
81 } 128 }
82 129
83 rv = VFY_Begin(vfy_context_); 130 rv = VFY_Begin(vfy_context_);
84 if (rv != SECSuccess) { 131 if (rv != SECSuccess) {
85 NOTREACHED(); 132 NOTREACHED();
86 return false; 133 return false;
87 } 134 }
88 return true; 135 return true;
89 } 136 }
90 137
138 bool SignatureVerifier::VerifyInitRSAPSS(HashAlgorithm hash_alg,
139 HashAlgorithm mask_hash_alg,
140 int salt_len,
141 const uint8* signature,
142 int signature_len,
143 const uint8* public_key_info,
144 int public_key_info_len) {
145 if (vfy_context_ || hash_context_)
146 return false;
147
148 signature_.assign(signature, signature + signature_len);
149
150 SECKEYPublicKey* public_key = DecodePublicKeyInfo(public_key_info,
151 public_key_info_len);
152 if (!public_key)
153 return false;
154
155 public_key_ = public_key;
156 hash_alg_ = hash_alg;
157 mask_hash_alg_ = mask_hash_alg;
158 salt_len_ = salt_len;
159 hash_context_ = HASH_Create(ToNSSHashType(hash_alg_));
160 if (!hash_context_)
161 return false;
162 HASH_Begin(hash_context_);
163 return true;
164 }
165
91 void SignatureVerifier::VerifyUpdate(const uint8* data_part, 166 void SignatureVerifier::VerifyUpdate(const uint8* data_part,
92 int data_part_len) { 167 int data_part_len) {
93 SECStatus rv = VFY_Update(vfy_context_, data_part, data_part_len); 168 if (vfy_context_) {
94 DCHECK_EQ(SECSuccess, rv); 169 SECStatus rv = VFY_Update(vfy_context_, data_part, data_part_len);
170 DCHECK_EQ(SECSuccess, rv);
171 } else {
172 HASH_Update(hash_context_, data_part, data_part_len);
173 }
95 } 174 }
96 175
97 bool SignatureVerifier::VerifyFinal() { 176 bool SignatureVerifier::VerifyFinal() {
98 SECStatus rv = VFY_End(vfy_context_); 177 SECStatus rv;
178 if (vfy_context_) {
179 rv = VFY_End(vfy_context_);
180 } else {
181 rv = VerifyRSAPSS_End(public_key_, hash_context_,
182 ToNSSHashType(mask_hash_alg_), salt_len_,
183 signature_.data(),
184 signature_.size());
185 }
99 Reset(); 186 Reset();
100 187
101 // If signature verification fails, the error code is 188 // If signature verification fails, the error code is
102 // SEC_ERROR_BAD_SIGNATURE (-8182). 189 // SEC_ERROR_BAD_SIGNATURE (-8182).
103 return (rv == SECSuccess); 190 return (rv == SECSuccess);
104 } 191 }
105 192
193 // static
194 SECKEYPublicKey* SignatureVerifier::DecodePublicKeyInfo(
195 const uint8* public_key_info,
196 int public_key_info_len) {
197 CERTSubjectPublicKeyInfo* spki = NULL;
198 SECItem spki_der;
199 spki_der.type = siBuffer;
200 spki_der.data = const_cast<uint8*>(public_key_info);
201 spki_der.len = public_key_info_len;
202 spki = SECKEY_DecodeDERSubjectPublicKeyInfo(&spki_der);
203 if (!spki)
204 return NULL;
205 SECKEYPublicKey* public_key = SECKEY_ExtractPublicKey(spki);
206 SECKEY_DestroySubjectPublicKeyInfo(spki); // Done with spki.
207 return public_key;
208 }
209
106 void SignatureVerifier::Reset() { 210 void SignatureVerifier::Reset() {
107 if (vfy_context_) { 211 if (vfy_context_) {
108 VFY_DestroyContext(vfy_context_, PR_TRUE); 212 VFY_DestroyContext(vfy_context_, PR_TRUE);
109 vfy_context_ = NULL; 213 vfy_context_ = NULL;
110 } 214 }
215 if (hash_context_) {
216 HASH_Destroy(hash_context_);
217 hash_context_ = NULL;
218 }
219 if (public_key_) {
220 SECKEY_DestroyPublicKey(public_key_);
221 public_key_ = NULL;
222 }
111 signature_.clear(); 223 signature_.clear();
112 } 224 }
113 225
114 } // namespace crypto 226 } // namespace crypto
OLDNEW
« no previous file with comments | « crypto/signature_verifier.h ('k') | crypto/signature_verifier_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698