S390: Platform specific includes in common files

S390: Platform specific includes in common files

Add S390 platform specific \#includes across various common files.
Add S390 CPU features to enum.
Add S390 implementation to extract sp/fp/pc from signal context.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com
BUG=

Committed: https://crrev.com/daea0e751866c4b96cecf65f04693fcd93b30cfa
Cr-Commit-Position: refs/heads/master@{#34674}

[JoranSiu, 2016-03-08 22:20:51]

The CQ bit was checked by joransiu@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 22:20:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777593003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777593003/1

[commit-bot: I haz the power, 2016-03-08 22:45:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 22:45:17]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2016-03-09 10:23:33]

LGTM.

This needs OWNERS reviews for src/interpreter/ and src/snapshot/.

[Michael Starzinger, 2016-03-09 10:25:11]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-03-09 10:25:12]

LGTM stamp for "interpreter", didn't look at anything else.

[Yang, 2016-03-09 10:43:18]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-03-09 10:43:18]

https://codereview.chromium.org/1777593003/diff/1/src/snapshot/deserializer.cc
File src/snapshot/deserializer.cc (right):

https://codereview.chromium.org/1777593003/diff/1/src/snapshot/deserializer.c...
src/snapshot/deserializer.cc:590: // a pointer to it to the current object.
Required only for MIPS, PPC or
Can you update the comment?

Actually I would prefer introducing a new #define to abbreviate this #ifdef.
Something like CODE_EMBEDS_OBJECT_POINTER.

[JoranSiu, 2016-03-09 15:37:08]

On 2016/03/09 10:43:18, Yang wrote:
> https://codereview.chromium.org/1777593003/diff/1/src/snapshot/deserializer.cc
> File src/snapshot/deserializer.cc (right):
> 
>
https://codereview.chromium.org/1777593003/diff/1/src/snapshot/deserializer.c...
> src/snapshot/deserializer.cc:590: // a pointer to it to the current object.
> Required only for MIPS, PPC or
> Can you update the comment?
> 
> Actually I would prefer introducing a new #define to abbreviate this #ifdef.
> Something like CODE_EMBEDS_OBJECT_POINTER.

@Yang, thanks for the review and suggestion.  Perhaps an alternative is to
consolidate the platform checks behind the existing: V8_EMBEDDED_CONSTANT_POOL,
which is currently defined on PPC only.  I'm not familiar with the history
behind this #define, and it's limited in its usage atm.  However, I suspect it
won't be conceptually wrong to define that for ARM and MIPS as well.  Thoughts?

[Yang, 2016-03-09 16:04:41]

yangguo@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Yang, 2016-03-09 16:04:42]

Interesting. From the comment here I would have expected that ARM has
V8_EMBEDDED_CONSTANT_POOL defined in some cases. But it seems not to be the
case. Ross, could you shed some light on this?

[rmcilroy, 2016-03-09 16:35:11]

On 2016/03/09 16:04:42, Yang wrote:
> Interesting. From the comment here I would have expected that ARM has
> V8_EMBEDDED_CONSTANT_POOL defined in some cases. But it seems not to be the
> case. Ross, could you shed some light on this?

ARM can run with V8_EMBEDDED_CONSTANT_POOL however the default is that it
doesn't. Please don't change V8_EMBEDDED_CONSTANT_POOL for other architectures -
it defines whether the architecture uses a constant pool pointer, which
currently is only PPC (and ARM if it is built with V8_EMBEDDED_CONSTANT_POOL).

[JoranSiu, 2016-03-10 06:01:12]

On 2016/03/09 16:35:11, rmcilroy wrote:
> On 2016/03/09 16:04:42, Yang wrote:
> > Interesting. From the comment here I would have expected that ARM has
> > V8_EMBEDDED_CONSTANT_POOL defined in some cases. But it seems not to be the
> > case. Ross, could you shed some light on this?
> 
> ARM can run with V8_EMBEDDED_CONSTANT_POOL however the default is that it
> doesn't. Please don't change V8_EMBEDDED_CONSTANT_POOL for other architectures
-
> it defines whether the architecture uses a constant pool pointer, which
> currently is only PPC (and ARM if it is built with V8_EMBEDDED_CONSTANT_POOL).

Thanks Ross and Yang for the clarification!

The latest patch contains the updated comments and the new macro
V8_CODE_EMBEDS_OBJECT_POINTER.  Given its scope, I've defined it in
deserializer.h, but please do let me know if it makes more sense to to define it
in some other header (i.e. globals.h, etc).

[Yang, 2016-03-10 06:02:53]

On 2016/03/10 06:01:12, JoranSiu wrote:
> On 2016/03/09 16:35:11, rmcilroy wrote:
> > On 2016/03/09 16:04:42, Yang wrote:
> > > Interesting. From the comment here I would have expected that ARM has
> > > V8_EMBEDDED_CONSTANT_POOL defined in some cases. But it seems not to be
the
> > > case. Ross, could you shed some light on this?
> > 
> > ARM can run with V8_EMBEDDED_CONSTANT_POOL however the default is that it
> > doesn't. Please don't change V8_EMBEDDED_CONSTANT_POOL for other
architectures
> -
> > it defines whether the architecture uses a constant pool pointer, which
> > currently is only PPC (and ARM if it is built with
V8_EMBEDDED_CONSTANT_POOL).
> 
> Thanks Ross and Yang for the clarification!
> 
> The latest patch contains the updated comments and the new macro
> V8_CODE_EMBEDS_OBJECT_POINTER.  Given its scope, I've defined it in
> deserializer.h, but please do let me know if it makes more sense to to define
it
> in some other header (i.e. globals.h, etc).

LGTM. Thanks!

[JoranSiu, 2016-03-10 12:55:58]

The CQ bit was checked by joransiu@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 12:56:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777593003/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777593003/50001

[commit-bot: I haz the power, 2016-03-10 13:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 13:29:06]

Dry run: This issue passed the CQ dry run.

[JoranSiu, 2016-03-10 14:00:47]

The CQ bit was checked by joransiu@ca.ibm.com

[JoranSiu, 2016-03-10 14:00:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1777593003/#ps50001
(title: "Use new Macro for object in roots array too.")

[commit-bot: I haz the power, 2016-03-10 14:01:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777593003/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777593003/50001

[commit-bot: I haz the power, 2016-03-10 14:02:56]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-03-10 14:03:59]

Description was changed from

==========
S390: Platform specific includes in common files

Add S390 platform specific \#includes across various common files.
Add S390 CPU features to enum.
Add S390 implementation to extract sp/fp/pc from signal context.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.c...
BUG=
==========

to

==========
S390: Platform specific includes in common files

Add S390 platform specific \#includes across various common files.
Add S390 CPU features to enum.
Add S390 implementation to extract sp/fp/pc from signal context.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.c...
BUG=

Committed: https://crrev.com/daea0e751866c4b96cecf65f04693fcd93b30cfa
Cr-Commit-Position: refs/heads/master@{#34674}
==========

[commit-bot: I haz the power, 2016-03-10 14:04:00]

Patchset 4 (id:??) landed as
https://crrev.com/daea0e751866c4b96cecf65f04693fcd93b30cfa
Cr-Commit-Position: refs/heads/master@{#34674}