Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1777573005: Fully specify libmicrohttpd.a path in build. (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fully specify libmicrohttpd.a path in build. This is more uniform and also makes things work with the cmake gyp generator. Committed: https://skia.googlesource.com/skia/+/f1255953e2876f43a8a0b5660aa63b42980d0d1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gyp/microhttpd.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777573005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777573005/1
4 years, 9 months ago (2016-03-09 16:44:03 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-09 16:44:04 UTC) #5
bungeman-skia
One last thing...
4 years, 9 months ago (2016-03-09 16:45:34 UTC) #7
joshualitt
On 2016/03/09 16:45:34, bungeman1 wrote: > One last thing... lgtm
4 years, 9 months ago (2016-03-09 16:53:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777573005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777573005/1
4 years, 9 months ago (2016-03-09 16:54:54 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 18:12:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f1255953e2876f43a8a0b5660aa63b42980d0d1d

Powered by Google App Engine
This is Rietveld 408576698