Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1777563002: X87: [turbofan] Further fixing ES6 tail call elimination in Turbofan. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Further fixing ES6 tail call elimination in Turbofan. port 2aae579cf04b24f605d1ae6b975d67d8dbbee672 (r34566) original commit message: In case when F tail calls G we should also remove the potential arguments adaptor frame for F. This CL introduces two new machine instructions ArchTailCallCodeObjectFromJSFunction and ArchTailCallJSFunctionFromJSFunction which (unlike existing ArchTailCallCodeObject and ArchTailCallJSFunction) also drop arguments adaptor frame if it exists right before jumping to the target function. BUG= Committed: https://crrev.com/26abfc5099a89847320975f3f1d76a8bff9bc056 Cr-Commit-Position: refs/heads/master@{#34593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -16 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 5 chunks +50 lines, -2 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 5 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-08 15:17:27 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-08 15:33:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777563002/1
4 years, 9 months ago (2016-03-08 15:35:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 16:13:55 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 16:14:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26abfc5099a89847320975f3f1d76a8bff9bc056
Cr-Commit-Position: refs/heads/master@{#34593}

Powered by Google App Engine
This is Rietveld 408576698