[bindings] ship "IterableCollections"

[bindings] ship "IterableCollections"

Enable and remove flag for runtime-enabled feature "IterableCollections"

This adds Symbol.iterator to WebIDL interfaces containing both an attribute named "length",
and an integer-indexed property getter, per http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList, DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement, HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList, TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist. Like the above interfaces,
NodeLists are also iterable via ECMAScript for-of loops.

Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FWu2lHOCbNg

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org, philipj@opera.com

Committed: https://crrev.com/2f9367a3f1bc731e1cae19edfa3b89bc18071093
Cr-Commit-Position: refs/heads/master@{#381249}

[caitp (gmail), 2016-03-10 19:38:06]

Description was changed from

==========
[bindings] ship "IterableCollections"

Enable runtime-enabled feature "IterableCollections" by default.

BUG=538558
LOG=N
R=haraken@chromium.org, yoshiino@chromium.org, jsbell@chromium.org
==========

to

==========
[bindings] ship "IterableCollections"

Enable runtime-enabled feature "IterableCollections" by default.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org
==========

[caitp (gmail), 2016-03-10 19:38:06]

caitpotter88@gmail.com changed reviewers:
+ yukishiino@chromium.org
- yoshiino@chromium.org

[caitp (gmail), 2016-03-10 19:38:38]

Fixed mistake with the reviewer email, derp.

[caitp (gmail), 2016-03-10 20:32:49]

PTAL --- There are a few questions I have:

1. What is the correct thing to do with ValueIterators? Enabling the flag by
default seems to expose NodeList.prototype[ @@iterator ] --- which is great, but
WebIDL is confusing me as to whether this needs to actually use Array.prototype
methods for each iterator method, or if the prototype of the ValueIterator thing
needs to be ArrayIterator's prototype, or what. It's a bit confusing. Maybe it
doesn't matter a whole lot, though.

2. Does this need to go through the full launch process, with chromestatus
updates and intent threads? I assume it does, but it's a very small feature.

[Yuki, 2016-03-11 06:50:16]

On 2016/03/10 20:32:49, caitp wrote:
> PTAL --- There are a few questions I have:
> 
> 1. What is the correct thing to do with ValueIterators? Enabling the flag by
> default seems to expose NodeList.prototype[ @@iterator ] --- which is great,
but
> WebIDL is confusing me as to whether this needs to actually use
Array.prototype
> methods for each iterator method, or if the prototype of the ValueIterator
thing
> needs to be ArrayIterator's prototype, or what. It's a bit confusing. Maybe it
> doesn't matter a whole lot, though.

According to http://heycam.github.io/webidl/#es-iterators ,
since NoteList defines an indexed property getter,
NodeList.prototype[@@iterator] must be %ArrayProto_values% that is
the initial value of Array.prototype[@@iterator].

We're doing wrong for this point.  But I think it's a separate issue
from this CL.


> 2. Does this need to go through the full launch process, with chromestatus
> updates and intent threads? I assume it does, but it's a very small feature.

Maybe yes, even if it's a small feature.

[jsbell, 2016-03-11 19:17:07]

jsbell@chromium.org changed reviewers:
+ philipj@opera.com

[jsbell, 2016-03-11 19:17:08]

+philipj

Please update the CL description with more details. 

Expectations for virtual/stable/webexposed/global-interface-listing.html need to
be updated:

https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_oilp...

Also... we don't have a "webexposed" test that shows that this enables
HTMLCollection.prototype[Symbol.iterator] in stable. I'd be a huge fan of adding
Object.getOwnPropertySymbols() iteration to the dumping code in
webexposed/resources/global-interface-listing.js

[caitp (gmail), 2016-03-11 19:20:58]

On 2016/03/11 19:17:08, jsbell wrote:
> +philipj
> 
> Please update the CL description with more details. 
> 
> Expectations for virtual/stable/webexposed/global-interface-listing.html need
to
> be updated:
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_oilp...
> 

Yeah, I just did that a few moments ago

> Also... we don't have a "webexposed" test that shows that this enables
> HTMLCollection.prototype[Symbol.iterator] in stable. I'd be a huge fan of
adding
> Object.getOwnPropertySymbols() iteration to the dumping code in
> webexposed/resources/global-interface-listing.js

I think we can do that --- maybe in a followup CL?

[philipj_slow, 2016-03-11 19:23:13]

https://codereview.chromium.org/1777483012/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/1777483012/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:104:
IterableCollections status=stable
I think you might just as well drop the runtime flag entirely, this is easy to
revert if needed. Stable features just seems to accumulate :)

[philipj_slow, 2016-03-11 19:26:07]

On 2016/03/11 19:20:58, caitp wrote:
> On 2016/03/11 19:17:08, jsbell wrote:
> > Also... we don't have a "webexposed" test that shows that this enables
> > HTMLCollection.prototype[Symbol.iterator] in stable. I'd be a huge fan of
> adding
> > Object.getOwnPropertySymbols() iteration to the dumping code in
> > webexposed/resources/global-interface-listing.js
> 
> I think we can do that --- maybe in a followup CL?

A CL that lands before this one would be nice, to show clearly which interfaces
will be affected by this CL (after rebasing). I finally figured out that
bindings/templates/interface_base.cpp uses
RuntimeEnabledFeatures::iterableCollectionsEnabled and that's why I could grep
my way to anything other than NodeList.

[caitp (gmail), 2016-03-11 19:27:38]

Description was changed from

==========
[bindings] ship "IterableCollections"

Enable runtime-enabled feature "IterableCollections" by default.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org
==========

to

==========
[bindings] ship "IterableCollections"

Enable runtime-enabled feature "IterableCollections" by default.

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length", and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators. Currently, this applies to
HTMLCollection, HTMLAllCollection, HTMLFormControlsCollection, and
HTMLOptionsCollection.

Additionally, the NodeList interface has methods "forEach", "keys", "values",
and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

[caitp (gmail), 2016-03-11 20:09:09]

On 2016/03/11 19:26:07, philipj_UTC7 wrote:
> On 2016/03/11 19:20:58, caitp wrote:
> > On 2016/03/11 19:17:08, jsbell wrote:
> > > Also... we don't have a "webexposed" test that shows that this enables
> > > HTMLCollection.prototype[Symbol.iterator] in stable. I'd be a huge fan of
> > adding
> > > Object.getOwnPropertySymbols() iteration to the dumping code in
> > > webexposed/resources/global-interface-listing.js
> > 
> > I think we can do that --- maybe in a followup CL?
> 
> A CL that lands before this one would be nice, to show clearly which
interfaces
> will be affected by this CL (after rebasing). I finally figured out that
> bindings/templates/interface_base.cpp uses
> RuntimeEnabledFeatures::iterableCollectionsEnabled and that's why I could grep
> my way to anything other than NodeList.

I've added https://codereview.chromium.org/1788503005/ to add symbols to layout
tests, which is currently being tried to find all the expectations updates that
are needed

[caitp (gmail), 2016-03-14 15:01:24]

Description was changed from

==========
[bindings] ship "IterableCollections"

Enable runtime-enabled feature "IterableCollections" by default.

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length", and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators. Currently, this applies to
HTMLCollection, HTMLAllCollection, HTMLFormControlsCollection, and
HTMLOptionsCollection.

Additionally, the NodeList interface has methods "forEach", "keys", "values",
and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

to

==========
[bindings] ship "IterableCollections"

Enable runtime-enabled feature "IterableCollections" by default.

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length", and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators. Such interfaces are now iterable
via ECMAScript for-of loops. Currently, this applies to the following
interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList, FileList, HTMLAllCollection, HTMLCollection,
HTMLFormElement, HTMLOptionsCollection, HTMLSelectElement, MediaList,
MimeTypeArray, NamedNodeMap, Plugin, PluginArray, SVGLengthList, SVGNumberList,
SVGPointList, SVGStringList, SVGTransformList, SourceBufferList, Storage,
StyleSheetList, TextTrackCueList, TextTrackList, TouchList, and
webkitSpeechGrammarList

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach", "keys", "values", and "entries", due to the `iterable<Node>`
definition in https://dom.spec.whatwg.org/#interface-nodelist.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

[caitp (gmail), 2016-03-14 15:02:20]

Description was changed from

==========
[bindings] ship "IterableCollections"

Enable runtime-enabled feature "IterableCollections" by default.

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length", and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators. Such interfaces are now iterable
via ECMAScript for-of loops. Currently, this applies to the following
interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList, FileList, HTMLAllCollection, HTMLCollection,
HTMLFormElement, HTMLOptionsCollection, HTMLSelectElement, MediaList,
MimeTypeArray, NamedNodeMap, Plugin, PluginArray, SVGLengthList, SVGNumberList,
SVGPointList, SVGStringList, SVGTransformList, SourceBufferList, Storage,
StyleSheetList, TextTrackCueList, TextTrackList, TouchList, and
webkitSpeechGrammarList

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach", "keys", "values", and "entries", due to the `iterable<Node>`
definition in https://dom.spec.whatwg.org/#interface-nodelist.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

to

==========
[bindings] ship "IterableCollections"

Enable runtime-enabled feature "IterableCollections" by default.

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

[caitp (gmail), 2016-03-14 15:02:59]

https://codereview.chromium.org/1777483012/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/1777483012/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:104:
IterableCollections status=stable
On 2016/03/11 19:23:12, philipj_UTC7 wrote:
> I think you might just as well drop the runtime flag entirely, this is easy to
> revert if needed. Stable features just seems to accumulate :)

I've removed the flag in the newest patchset

[caitp (gmail), 2016-03-14 15:03:55]

Description was changed from

==========
[bindings] ship "IterableCollections"

Enable runtime-enabled feature "IterableCollections" by default.

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

to

==========
[bindings] ship "IterableCollections"

Enable and remove flag for runtime-enabled feature "IterableCollections"

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

[caitp (gmail), 2016-03-14 15:04:42]

Description was changed from

==========
[bindings] ship "IterableCollections"

Enable and remove flag for runtime-enabled feature "IterableCollections"

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

to

==========
[bindings] ship "IterableCollections"

Enable and remove flag for runtime-enabled feature "IterableCollections"

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist. Like the above interfaces,
NodeLists are also iterable via ECMAScript for-of loops.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

[philipj_slow, 2016-03-14 16:06:29]

Looks good, but there are a lot more interfaces affected than I had guessed.
Which just means that I'm bad at guessing, but webkitSpeechGrammarList is among
them so that's not entirely obvious.

Maybe an Intent to Ship is appropriate here after all, if you just list the
affected interfaces and why this is awesome it should be smooth sailing. Perhaps
the outcome will be to exclude some interfaces, but if so I assume that won't be
particularly hard to support.

[caitp (gmail), 2016-03-14 16:35:13]

On 2016/03/14 16:06:29, philipj_UTC7 wrote:
> Looks good, but there are a lot more interfaces affected than I had guessed.
> Which just means that I'm bad at guessing, but webkitSpeechGrammarList is
among
> them so that's not entirely obvious.
> 
> Maybe an Intent to Ship is appropriate here after all, if you just list the
> affected interfaces and why this is awesome it should be smooth sailing.
Perhaps
> the outcome will be to exclude some interfaces, but if so I assume that won't
be
> particularly hard to support.

Fair enough, I'll write that up today.

[philipj_slow, 2016-03-15 04:55:48]

lgtm

If you can link to the blink-dev thread in the commit message, that would be
nice. (I often follow those when trying to find more discussion about a change.)

[philipj_slow, 2016-03-15 04:56:16]

I think you should wait for an LGTM for one of the bindings experts as well.

[Yuki, 2016-03-15 05:47:01]

LGTM.

[caitp (gmail), 2016-03-15 16:14:03]

Description was changed from

==========
[bindings] ship "IterableCollections"

Enable and remove flag for runtime-enabled feature "IterableCollections"

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist. Like the above interfaces,
NodeLists are also iterable via ECMAScript for-of loops.

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

to

==========
[bindings] ship "IterableCollections"

Enable and remove flag for runtime-enabled feature "IterableCollections"

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist. Like the above interfaces,
NodeLists are also iterable via ECMAScript for-of loops.

Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FWu2lHOCbNg

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

[caitp (gmail), 2016-03-15 16:14:48]

On 2016/03/15 04:56:16, philipj_UTC7 wrote:
> I think you should wait for an LGTM for one of the bindings experts as well.

Did you mean on the intent thread, or the CL?

[philipj_slow, 2016-03-15 16:30:50]

I meant this CL, so you're good to go!

[caitp (gmail), 2016-03-15 16:31:32]

On 2016/03/15 16:30:50, philipj_UTC7 wrote:
> I meant this CL, so you're good to go!

Okay, thanks :)

[caitp (gmail), 2016-03-15 16:31:39]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2016-03-15 16:31:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777483012/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777483012/80001

[commit-bot: I haz the power, 2016-03-15 17:53:04]

Description was changed from

==========
[bindings] ship "IterableCollections"

Enable and remove flag for runtime-enabled feature "IterableCollections"

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist. Like the above interfaces,
NodeLists are also iterable via ECMAScript for-of loops.

Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FWu2lHOCbNg

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

to

==========
[bindings] ship "IterableCollections"

Enable and remove flag for runtime-enabled feature "IterableCollections"

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist. Like the above interfaces,
NodeLists are also iterable via ECMAScript for-of loops.

Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FWu2lHOCbNg

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

[commit-bot: I haz the power, 2016-03-15 17:53:05]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-15 17:53:56]

Description was changed from

==========
[bindings] ship "IterableCollections"

Enable and remove flag for runtime-enabled feature "IterableCollections"

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist. Like the above interfaces,
NodeLists are also iterable via ECMAScript for-of loops.

Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FWu2lHOCbNg

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com
==========

to

==========
[bindings] ship "IterableCollections"

Enable and remove flag for runtime-enabled feature "IterableCollections"

This adds Symbol.iterator to WebIDL interfaces containing both an attribute
named "length",
and an integer-indexed property getter, per
http://heycam.github.io/webidl/#es-iterators.
Such interfaces are now iterable via ECMAScript for-of loops. Currently, this
applies to the
following interfaces:

CSSRuleList, CSSStyleDeclaration, ClientRectList, DOMStringList,
DataTransferItemList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement,
HTMLOptionsCollection,
HTMLSelectElement, MediaList, MimeTypeArray, NamedNodeMap, Plugin, PluginArray,
SVGLengthList, SVGNumberList, SVGPointList, SVGStringList, SVGTransformList,
SourceBufferList, Storage, StyleSheetList, TextTrackCueList, TextTrackList,
TouchList, and
webkitSpeechGrammarList.

In addition to the above interfaces, the NodeList interface is granted the
methods "forEach",
"keys", "values", and "entries", due to the `iterable<Node>` definition in
https://dom.spec.whatwg.org/#interface-nodelist. Like the above interfaces,
NodeLists are also iterable via ECMAScript for-of loops.

Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FWu2lHOCbNg

BUG=538558
LOG=N
R=haraken@chromium.org, yukishiino@chromium.org, jsbell@chromium.org,
philipj@opera.com

Committed: https://crrev.com/2f9367a3f1bc731e1cae19edfa3b89bc18071093
Cr-Commit-Position: refs/heads/master@{#381249}
==========

[commit-bot: I haz the power, 2016-03-15 17:53:57]

Patchset 5 (id:??) landed as
https://crrev.com/2f9367a3f1bc731e1cae19edfa3b89bc18071093
Cr-Commit-Position: refs/heads/master@{#381249}