Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1777483011: Resort to presubmit style. (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-10 12:31:33 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4bbd051acc0cd3b162a6959c7fab5d785f0f3635 Cr-Commit-Position: refs/heads/master@{#34667}
4 years, 9 months ago (2016-03-10 12:34:14 UTC) #5
Toon Verwaest
Committed patchset #1 (id:1) manually as 4bbd051acc0cd3b162a6959c7fab5d785f0f3635 (tree was closed).
4 years, 9 months ago (2016-03-10 12:34:18 UTC) #7
Michael Achenbach
4 years, 9 months ago (2016-03-10 12:35:26 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698