Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1777483008: Move the grid-gap shorthand into CSSPropertyParser (Closed)

Created:
4 years, 9 months ago by rwlbuis
Modified:
4 years, 9 months ago
Reviewers:
Timothy Loh, jfernandez
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the grid-gap shorthand into CSSPropertyParser Move the grid-gap shorthand from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/1a6bfa1bbdbc077202e6637cdf7afe28083bfcbc Cr-Commit-Position: refs/heads/master@{#380897}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -38 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 chunks +0 lines, -37 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rwlbuis
PTAL.
4 years, 9 months ago (2016-03-11 16:57:55 UTC) #4
Timothy Loh
On 2016/03/11 16:57:55, rwlbuis wrote: > PTAL. lgtm
4 years, 9 months ago (2016-03-13 12:42:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777483008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777483008/20001
4 years, 9 months ago (2016-03-13 15:08:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-13 16:18:34 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-13 16:19:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a6bfa1bbdbc077202e6637cdf7afe28083bfcbc
Cr-Commit-Position: refs/heads/master@{#380897}

Powered by Google App Engine
This is Rietveld 408576698