Issue 1777483006: Recognize identical() ConstantValues as equal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1777483006: Recognize identical() ConstantValues as equal. (Closed)

Created:
4 years, 9 months ago by sra1

Modified:
4 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Recognize identical() ConstantValues as equal. This fast path is not used when interning ConstantValues but is beneficial when the ConstantValue is the key of a HashMap. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/d367741eada8b8ab424fcb0749955f6992c7319b

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/constants/values.dart	View		4 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

4 years, 9 months ago (2016-03-09 01:18:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d367741eada8b8ab424fcb0749955f6992c7319b (presubmit successful).