Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1777483005: Prepare content/ module for compilation with OS X 10.7 deployment target. (Closed)

Created:
4 years, 9 months ago by erikchen
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, dcheng, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp89_107_ui
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare content/ module for compilation with OS X 10.7 deployment target. Replaced deprecated methods convertBaseToScreen: and convertBaseFromScreen: with ConvertPointFromWindowToScreen and ConvertPointFromScreenToWindow. Fixed a unit test in render_widget_host_view_mac_unittest.mm, and a real bug in web_contents_view_mac.mm. BUG=592663 Committed: https://crrev.com/51f7d244880eb22d403f2c9731c0e733541ab632 Cr-Commit-Position: refs/heads/master@{#380521}

Patch Set 1 #

Patch Set 2 : Nits #

Patch Set 3 : Fix bugs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M content/browser/renderer_host/input/web_input_event_builders_mac.mm View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 6 chunks +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 2 1 chunk +8 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 32 (15 generated)
erikchen
avi: Please review.
4 years, 9 months ago (2016-03-08 21:43:25 UTC) #2
Avi (use Gerrit)
lgtm 👍
4 years, 9 months ago (2016-03-08 21:54:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777483005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777483005/20001
4 years, 9 months ago (2016-03-08 23:52:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/170552)
4 years, 9 months ago (2016-03-09 00:10:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777483005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777483005/20001
4 years, 9 months ago (2016-03-09 00:30:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/192208)
4 years, 9 months ago (2016-03-09 01:39:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777483005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777483005/20001
4 years, 9 months ago (2016-03-09 01:47:47 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/192291)
4 years, 9 months ago (2016-03-09 03:10:06 UTC) #15
erikchen
avi: PTAL. You can diff patch sets 2 and 3. The unit tests caught real ...
4 years, 9 months ago (2016-03-10 18:33:23 UTC) #18
Avi (use Gerrit)
Still lgtm
4 years, 9 months ago (2016-03-10 19:26:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777483005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777483005/40001
4 years, 9 months ago (2016-03-10 19:30:23 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/193428)
4 years, 9 months ago (2016-03-10 21:54:56 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777483005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777483005/40001
4 years, 9 months ago (2016-03-10 21:57:35 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/193674)
4 years, 9 months ago (2016-03-11 01:00:26 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777483005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777483005/40001
4 years, 9 months ago (2016-03-11 01:32:01 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-11 05:19:26 UTC) #30
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 05:21:57 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/51f7d244880eb22d403f2c9731c0e733541ab632
Cr-Commit-Position: refs/heads/master@{#380521}

Powered by Google App Engine
This is Rietveld 408576698