Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1777483002: Revert of Suppress races on ConvertableToTraceFormat refcounters. (Closed)

Created:
4 years, 9 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Suppress races on ConvertableToTraceFormat refcounters. (patchset #1 id:1 of https://codereview.chromium.org/1602773002/ ) Reason for revert: AsConvertableToTraceFormat should not be racy anymore after the mega-tracing refactoring of crrev.com/1717283003 Original issue's description: > Suppress races on ConvertableToTraceFormat refcounters. > > BUG=559117 > TBR=reillyg@chromium.org > NOTRY=true > > Committed: https://crrev.com/78c43a90883198b3e2c86c994507ab8cba0aac87 > Cr-Commit-Position: refs/heads/master@{#370033} TBR=reillyg@chromium.org,glider@chromium.org BUG=559117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Primiano Tucci (use gerrit)
Created Revert of Suppress races on ConvertableToTraceFormat refcounters.
4 years, 9 months ago (2016-03-08 11:03:09 UTC) #1
Sami
lgtm yay
4 years, 9 months ago (2016-03-08 11:05:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777483002/1
4 years, 9 months ago (2016-03-08 11:06:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/141687)
4 years, 9 months ago (2016-03-08 11:08:32 UTC) #8
Primiano Tucci (use gerrit)
On 2016/03/08 11:08:32, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-03-08 11:09:10 UTC) #9
Primiano Tucci (use gerrit)
4 years, 9 months ago (2016-03-08 11:15:38 UTC) #10
On 2016/03/08 11:09:10, Primiano wrote:
> On 2016/03/08 11:08:32, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
> 
> http://sadtrombone.com, 3 way merge fail. Falling back to good old manual
conflict
> resolution.

Ok I needed a different change. CLosing this issue.
https://codereview.chromium.org/1772873004/ is the right revert.

Powered by Google App Engine
This is Rietveld 408576698