Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: net/quic/quic_packet_generator.h

Issue 1777423002: Remove max_packet_length from QuicPacketGenerator, because it is no longer necessary with FEC gone.… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116277228
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_packet_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_generator.h
diff --git a/net/quic/quic_packet_generator.h b/net/quic/quic_packet_generator.h
index d0b392a49d851d1b94293eafcec00ce71a9c43cf..881d97392ceebba4ff2b2f92697d5a8a72589b9e 100644
--- a/net/quic/quic_packet_generator.h
+++ b/net/quic/quic_packet_generator.h
@@ -148,14 +148,11 @@ class NET_EXPORT_PRIVATE QuicPacketGenerator {
// created.
QuicPacketNumber packet_number() const;
- // Returns the maximum packet length. Note that this is the long-term maximum
- // packet length, and it may not be the maximum length of the current packet,
- // if the generator is in the middle of the packet (in batch mode).
- QuicByteCount GetMaxPacketLength() const;
- // Returns the maximum length current packet can actually have.
+ // Returns the maximum length a current packet can actually have.
QuicByteCount GetCurrentMaxPacketLength() const;
- // Set maximum packet length at the next opportunity.
+ // Set maximum packet length in the creator immediately. May not be called
+ // when there are frames queued in the creator.
void SetMaxPacketLength(QuicByteCount length);
// Sets |path_id| to be the path on which next packet is generated.
@@ -201,11 +198,6 @@ class NET_EXPORT_PRIVATE QuicPacketGenerator {
QuicAckFrame pending_ack_frame_;
QuicStopWaitingFrame pending_stop_waiting_frame_;
- // Stores the maximum packet size we are allowed to send. This might not be
- // the maximum size we are actually using now, if we are in the middle of the
- // packet.
- QuicByteCount max_packet_length_;
-
DISALLOW_COPY_AND_ASSIGN(QuicPacketGenerator);
};
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_packet_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698