Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1777393003: Type inference cleanup (Closed)

Created:
4 years, 9 months ago by sra1
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Type inference cleanup - No longer attribute queries to type inference. Queries are attributed to client. - Remove vestigial CPA code - Don't compare target sets for additions and deletions if they are the same (most of the time we revisit the dynamic call site due to a change in a returned result). R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/dc95698672967efe09e3eba19cb0014bead8f1e6

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -59 lines) Patch
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 chunk +28 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 4 chunks +20 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
4 years, 9 months ago (2016-03-10 22:47:32 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 9 months ago (2016-03-11 00:22:08 UTC) #4
sra1
4 years, 9 months ago (2016-03-11 01:25:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dc95698672967efe09e3eba19cb0014bead8f1e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698