[Cronet] Fix race in UploadDataStream.attachToRequest.

components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java

Index: components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
index e03e97dde1463e8ce594a9b54d2bc6355fd0c5de..98f7ef525c897f40be61b01e05c5bc78b6197a71 100644
--- a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
+++ b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
@@ -211,10 +211,15 @@ final class CronetUrlRequest implements UrlRequest {
                                 "Requests with upload data must have a Content-Type.");
                     }
                     mStarted = true;
-                    mUploadDataStream.attachToRequest(this, mUrlRequestAdapter, new Runnable() {
+                    mUploadDataStream.postTaskToExecutor(new Runnable() {
                         @Override
                         public void run() {
+                            mUploadDataStream.initializeWithRequest(CronetUrlRequest.this);
                             synchronized (mUrlRequestAdapterLock) {
+                                if (isDoneLocked()) {

[xunjieli, 2016/03/10 20:32:21]

nit: use isDone() instead to avoid grabbing lock twice.

[mef, 2016/03/10 22:16:30]

isDoneLocked() is @GuardedBy lock instead of grabbing it:

    public boolean isDone() {
        synchronized (mUrlRequestAdapterLock) {
            return isDoneLocked();
        }
    }

[xunjieli, 2016/03/10 22:40:54]

Sorry, I got those two confused..

[mef, 2016/03/11 15:43:06]

NP, I'm not sure whether there is a better name suffix for this.

+                                    return;
+                                }
+                                mUploadDataStream.attachNativeAdapterToRequest(mUrlRequestAdapter);
                                 startInternalLocked();
                             }
                         }