components/cronet/tools/cr_cronet.py - Issue 1777333002: [Cronet] Fix race in UploadDataStream.attachToRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 1777333002: [Cronet] Fix race in UploadDataStream.attachToRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the comment. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/cronet/tools/cr_cronet.py

diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py

index f6d349025c8b0dd908f313f9b26b883fcf8abc7f..35633d7055f34821887ca5b489f11ee16d2326e2 100755

--- a/components/cronet/tools/cr_cronet.py

+++ b/components/cronet/tools/cr_cronet.py

@@ -70,10 +70,10 @@ def main():

print extra_options_list

gyp_defines = 'GYP_DEFINES="OS=android enable_websockets=0 '+ \

'disable_file_support=1 disable_ftp_support=1 '+ \

- 'enable_bidirectional_stream=1"'

+ 'enable_bidirectional_stream=1 enable_errorprone=1"'

gn_args = 'target_os="android" enable_websockets=false '+ \

'disable_file_support=true disable_ftp_support=true '+ \

- 'enable_bidirectional_stream=false'

+ 'enable_bidirectional_stream=false use_errorprone_java_compiler=true'

out_dir = 'out/Debug'

release_arg = ''

extra_options = ' '.join(extra_options_list)

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java ('k') | no next file » | no next file with comments »